parked

Author: JamesW1-NHS

.github/dependabot.yml

@@ -60,8 +60,8 @@ updates:
       - "/recordprocessor"
       - "/redis_sync"
       - "/lambdas/id_sync"
+      - "/lambdas/mns_subscription"
       - "/lambdas/shared"
-      - "/mns_subscription"
     schedule:
       interval: "daily"
     open-pull-requests-limit: 1

.github/workflows/sonarcloud.yml

@@ -123,16 +123,16 @@ jobs:
           poetry run coverage xml -o ../mesh_processor-coverage.xml
 
       - name: Run unittest with coverage-mns-subscription
-        working-directory: mns_subscription
+        working-directory: lambdas/mns_subscription
+        id: id_sync
         env:
-          PYTHONPATH: ${{ github.workspace }}/mns_subscription/src:${{ github.workspace }}/mns_subscription/tests
-        id: mns_subscription
+          PYTHONPATH: ${{ env.LAMBDA_PATH }}/mns_subscription/src:${{ env.SHARED_PATH }}/src
         continue-on-error: true
         run: |
-          poetry install
-          poetry run coverage run -m unittest discover || echo "mns_subscription tests failed" >> ../failed_tests.txt
-          poetry run coverage report -m
-          poetry run coverage xml -o ../mns_subscription-coverage.xml
+            poetry install
+            poetry run coverage run --rcfile=.coveragerc --source=src -m unittest discover || echo "mns_subscription tests failed" >> ../../failed_tests.txt
+            poetry run coverage report -m
+            poetry run coverage xml -o ../../mns_subscription-coverage.xml
 
       - name: Run unittest with redis_sync
         working-directory: redis_sync

Makefile

@@ -1,6 +1,6 @@
 SHELL=/usr/bin/env bash -euo pipefail
 
-PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS = ack_backend backend batch_processor_filter delta_backend filenameprocessor mesh_processor recordprocessor redis_sync lambdas/id_sync lambdas/shared mns_subscription
+PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS = ack_backend backend batch_processor_filter delta_backend filenameprocessor mesh_processor recordprocessor redis_sync lambdas/id_sync lambdas/mns_subscription lambdas/shared
 PYTHON_PROJECT_DIRS = e2e e2e_batch $(PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS)
 
 #Installs dependencies using poetry.

immunisation-fhir-api.code-workspace

@@ -31,10 +31,10 @@
             "path": "redis_sync"
         },
 		{
-            "path": "mns_subscription"
+			"path": "lambdas/id_sync"
         },
 		{
-			"path": "lambdas/id_sync"
+            "path": "lambdas/mns_subscription"
 		},
 		{
 			"path": "lambdas/shared"

lambdas/.coveragerc

@@ -6,3 +6,6 @@ omit =
     id_sync/tests/*
     id_sync/tests/*/*
     id_sync/tests/*/*/*
+    mns_subscription/tests/*
+    mns_subscription/tests/*/*
+    mns_subscription/tests/*/*/*

lambdas/mns_subscription/.vscode/settings.json.default

@@ -0,0 +1,27 @@
+{
+    "python.analysis.extraPaths": [
+        "./src"
+    ],
+    "python.testing.unittestArgs": [
+        "-v",
+        "-s",
+        "./",
+        "-p",
+        "test_*.py"
+    ],
+    "python.testing.pytestEnabled": false,
+    "python.testing.unittestEnabled": true,
+    "pylint.args": [
+        "--init-hook",
+        "import sys; sys.path.append('./src')"
+    ],
+    "[makefile]": {
+        "editor.insertSpaces": false,
+        "editor.detectIndentation": false
+    },
+    "files.trimTrailingWhitespace": true,
+    "[python]": {
+        "files.trimTrailingWhitespace": true
+    },
+    "files.insertFinalNewline": true
+}

lambdas/mns_subscription/Makefile

@@ -0,0 +1,21 @@
+subscribe:
+	@PYTHONPATH=src poetry run python src/subscribe_mns.py
+
+unsubscribe:
+	@PYTHONPATH=src poetry run python src/unsubscribe_mns.py
+
+TEST_ENV := @PYTHONPATH=src:tests:../shared/src
+
+test:
+	$(TEST_ENV) python -m unittest
+
+coverage-run:
+	$(TEST_ENV) coverage run -m unittest discover
+
+coverage-report:
+	$(TEST_ENV) coverage report -m 
+
+coverage-html:
+	$(TEST_ENV) coverage html
+
+.PHONY: build package test

lambdas/mns_subscription/poetry.lock

@@ -0,0 +1,23 @@
+[tool.poetry]
+name        = "mns-subscription"
+version     = "0.1.0"
+description = ""
+authors     = ["Your Name <[email protected]>"]
+packages = [
+    {include = "src"},
+    {include = "common", from = "../shared/src"}
+]
+
+[tool.poetry.dependencies]
+python                  = "~3.11"
+boto3                   = "~1.40.22"
+pyjwt                   = "~2.10.1"
+moto                    = "^5.1.11"
+coverage                = "^7.10.6"
+requests                = "~2.32.5"
+responses               = "~0.25.8"
+
+
+[build-system]
+requires = ["poetry-core"]
+build-backend = "poetry.core.masonry.api"