improve coverage: add test for lookup

Author: Akol125

lambdas/shared/src/common/validator/lookup_expressions/key_data.py

@@ -35,7 +35,7 @@ def __init__(self):
             "420254004",
         ]
 
-        self.route = [
+        self.route: list[str] = [
             "54471007",
             "372449004",
             "372450004",

lambdas/shared/tests/test_common/validator/test_application_fhir.py

@@ -1,6 +1,5 @@
 # Test application file
 import json
-import os
 import time
 import unittest
 from pathlib import Path
@@ -23,10 +22,6 @@ def test_validation(self):
         with open(self.schemaFilePath) as JSON:
             SchemaFile = json.load(JSON)
 
-        print("Current working directory:", os.getcwd())
-        print("Test file directory:", Path(__file__).parent)
-        print("Schema file exists:", (Path(__file__).parent / "schemas" / "test_schema.json").exists())
-
         validator = Validator(SchemaFile)  # FHIR File Path not needed
         error_list = validator.validate_fhir(self.FHIRFilePath, True, True, True)
         error_report = validator.build_error_report("25a8cc4d-1875-4191-ac6d-2d63a0ebc64b")  # include eventID if known

lambdas/shared/tests/test_common/validator/test_key_data.py

@@ -0,0 +1,45 @@
+import unittest
+
+from common.validator.lookup_expressions.key_data import KeyData
+
+
+class TestKeyData(unittest.TestCase):
+    def setUp(self):
+        self.kd = KeyData()
+
+    def test_site_valid_code(self):
+        self.assertTrue(self.kd.findKey("Site", "368208006"))
+
+    def test_site_invalid_code(self):
+        self.assertFalse(self.kd.findKey("Site", "not_a_code"))
+
+    def test_route_valid_code(self):
+        # pick one known code from route list
+        self.assertTrue(self.kd.findKey("Route", "54471007"))
+
+    def test_route_invalid_code(self):
+        self.assertFalse(self.kd.findKey("Route", "000000"))
+
+    def test_procedure_valid_code(self):
+        self.assertTrue(self.kd.findKey("Procedure", "956951000000104"))
+
+    def test_procedure_invalid_code(self):
+        self.assertFalse(self.kd.findKey("Procedure", "956951000000105"))
+
+    def test_organisation_valid_code(self):
+        self.assertTrue(self.kd.findKey("Organisation", "RJ1"))
+
+    def test_organisation_invalid_code(self):
+        self.assertFalse(self.kd.findKey("Organisation", "RJX"))
+
+    def test_unknown_key_source_returns_false(self):
+        self.assertFalse(self.kd.findKey("Unknown", "anything"))
+
+    def test_non_string_inputs_are_handled(self):
+        # ensure method is resilient and returns False for non-string without raising
+        self.assertFalse(self.kd.findKey("Site", None))
+        self.assertFalse(self.kd.findKey("Route", 12345))
+
+
+if __name__ == "__main__":
+    unittest.main()