tidy

Author: nhsdevws

.github/workflows/sonarcloud.yml

@@ -86,7 +86,6 @@ jobs:
           poetry install
           poetry run coverage run -m unittest discover || echo "delta tests failed" >> ../failed_tests.txt
           poetry run coverage xml -o ../delta-coverage.xml
-          cat ../delta-coverage.xml
 
       - name: Run unittest with coverage-fhir-api
         working-directory: backend
@@ -130,7 +129,6 @@ jobs:
             poetry install
             poetry run coverage run --rcfile=.coveragerc --source=src -m unittest discover -s tests -p "test_*.py" -v || echo "shared tests failed" >> ../../failed_tests.txt
             poetry run coverage xml -o ../../shared-coverage.xml
-            cat ../../shared-coverage.xml
 
       - name: Run unittest with id_sync
         working-directory: lambdas/id_sync
@@ -143,7 +141,6 @@ jobs:
             poetry install
             poetry run coverage run --rcfile=.coveragerc --source=src -m unittest discover || echo "id_sync tests failed" >> ../../failed_tests.txt
             poetry run coverage xml -o ../../id_sync-coverage.xml
-            cat ../../id_sync-coverage.xml
 
       - name: Run Test Failure Summary
         id: check_failure

azure/templates/post-deploy.yml

@@ -56,8 +56,6 @@ steps:
         echo Apigee environment: $APIGEE_ENVIRONMENT
         echo pr_no: $pr_no
 
-        echo "Output dirs"
-        ls
         cd terraform
 
         make init

lambdas/id_sync/tests/test_id_sync.py

@@ -1,6 +1,5 @@
 import unittest
 from unittest.mock import patch, MagicMock
-import json
 
 
 with patch('common.log_decorator.logging_decorator') as mock_decorator:

redis_sync/src/clients.py

@@ -8,8 +8,8 @@
 logger = logging.getLogger()
 logger.setLevel("INFO")
 
-STREAM_NAME = os.getenv("SPLUNK_FIREHOSE_NAME", "firehose-name-not-defined")
-CONFIG_BUCKET_NAME = os.getenv("CONFIG_BUCKET_NAME", "variconfig-bucketable-not-defined")
+STREAM_NAME = os.getenv("SPLUNK_FIREHOSE_NAME", "immunisation-fhir-api-internal-dev-splunk-firehose")
+CONFIG_BUCKET_NAME = os.getenv("CONFIG_BUCKET_NAME", "variable-not-defined")
 
 REGION_NAME = os.getenv("AWS_REGION", "eu-west-2")
 REDIS_HOST = os.getenv("REDIS_HOST", "")