review

Author: Akol125

azure/azure-pr-teardown-pipeline.yml

@@ -44,7 +44,7 @@ jobs:
           echo "##vso[task.setvariable variable=AWS_DEFAULT_REGION]eu-west-2"
           echo "##vso[task.setvariable variable=APIGEE_ENVIRONMENT]internal-dev"
         displayName: Set AWS default region and Terraform state bucket
-      
+
       - bash: |
           export AWS_PROFILE=apim-dev
           account_id="$(aws sts get-caller-identity --query Account --output text)"

azure/templates/post-deploy.yml

@@ -60,8 +60,6 @@ steps:
         echo pr_no: $pr_no
 
         cd terraform
-       
-
         make init
         make apply environment=${{ parameters.aws_account_type }} sub_environment=$workspace
 

mns_subscription/src/mns_service.py

@@ -90,14 +90,14 @@ def check_subscription(self) -> dict:
             logging.error(f"Error ensuring subscription: {e}")
             raise
 
-    def delete_subscription(self, subscription_id: str) -> bool:
+    def delete_subscription(self, subscription_id: str) -> str:
         """Delete the subscription by ID."""
         url = f"{MNS_URL}/{subscription_id}"
         response = requests.delete(url, headers=self.request_headers, timeout=10)
         if response.status_code == 204:
             logging.info(f"Deleted subscription {subscription_id}")
             print(f"{response.text}")
-            return "Subscription Succesfully Deleted..."
+            return "Subscription Successfully Deleted..."
         else:
             MnsService.handle_response(response)