Skip to content

Commit b311594

Browse files
committed
resolve final sonar errors
1 parent 953e840 commit b311594

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

lambdas/shared/src/common/validator/expression_checker.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,6 @@ def _validate_datetime(self, rule, field_name, field_value, row) -> ErrorReport:
8484
try:
8585
# Current behavior expects date-only; datetime raises and is handled below
8686
datetime.date.fromisoformat(field_value)
87-
# rule is not used - could be date only, date time, past, future etc
88-
if rule:
89-
pass
90-
9187
except RecordError as e:
9288
code = e.code if e.code is not None else ExceptionLevels.RECORD_CHECK_FAILED
9389
message = e.message if e.message is not None else MESSAGES[ExceptionLevels.RECORD_CHECK_FAILED]
@@ -119,16 +115,6 @@ def _validate_integer(self, expression_rule, field_name, field_value, row) -> Er
119115
try:
120116
int(field_value)
121117
if expression_rule:
122-
# TODO - code is incomplete here. It appears there should be a check
123-
# against expression_rule but it's not implemented. eg max, min, equal etc
124-
# eg "1" means value must be 1
125-
# "1:10" means value must be between 1 to 10
126-
# "1,10" means value must be either 1 or 10
127-
# ":10" means value must be less than or equal to 10
128-
# "1:" means value must be greater than or equal to 1
129-
# ">10" means value must be greater than 10
130-
# "<10" means value must be less than 10
131-
132118
check_value = int(expression_rule)
133119
if int(field_value) != check_value:
134120
raise RecordError(

0 commit comments

Comments
 (0)