Resolved comments

robertnovac1 · robertnovac1 · commit b5e2bd3d4785 · 2025-07-23T10:54:25.000+01:00
diff --git a/terraform/.terraform.lock.hcl b/terraform/.terraform.lock.hcl
diff --git a/terraform/main.tf b/terraform/main.tf
@@ -21,7 +21,7 @@ provider "aws" {
   default_tags {
     tags = {
       Project     = var.project_name
-      Environment = var.has_sub_environment_scope ? var.sub_environment : var.environment
+      Environment = local.resource_scope
       Service     = var.service
     }
   }
diff --git a/terraform/redis_sync_lambda.tf b/terraform/redis_sync_lambda.tf
@@ -67,7 +67,6 @@ resource "aws_ecr_repository_policy" "redis_sync_lambda_ECRImageRetreival_policy
         ],
         Condition : {
           StringLike : {
-            # "aws:sourceArn" : "arn:aws:lambda:eu-west-2:${var.immunisation_account_id}:function:${local.short_prefix}-redis_sync_lambda"
             "aws:sourceArn" : aws_lambda_function.redis_sync_lambda.arn
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ provider "aws" {`
`21`	`21`	`default_tags {`
`22`	`22`	`tags = {`
`23`	`23`	`Project = var.project_name`
`24`		`- Environment = var.has_sub_environment_scope ? var.sub_environment : var.environment`
	`24`	`+ Environment = local.resource_scope`
`25`	`25`	`Service = var.service`
`26`	`26`	`}`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@ resource "aws_ecr_repository_policy" "redis_sync_lambda_ECRImageRetreival_policy`
`67`	`67`	`],`
`68`	`68`	`Condition : {`
`69`	`69`	`StringLike : {`
`70`		`- # "aws:sourceArn" : "arn:aws:lambda:eu-west-2:${var.immunisation_account_id}:function:${local.short_prefix}-redis_sync_lambda"`
`71`	`70`	`"aws:sourceArn" : aws_lambda_function.redis_sync_lambda.arn`
`72`	`71`	`}`
`73`	`72`	`}`