VED-368 Dose Number Maximum (#736)

* DoseNumber Maximum

* Maximum value is 9

* dose_number unit tests

Author: nhsdevws

backend/src/models/fhir_immunization_pre_validators.py

@@ -626,16 +626,16 @@ def pre_validate_protocol_applied(self, values: dict) -> dict:
             PreValidation.for_list(field_value, "protocolApplied", defined_length=1)
         except KeyError:
             pass
-
+    DOSE_NUMBER_MAX_VALUE = 9
     def pre_validate_dose_number_positive_int(self, values: dict) -> dict:
         """
         Pre-validate that, if protocolApplied[0].doseNumberPositiveInt (legacy CSV field : dose_sequence)
-        exists, then it is an integer from 1 to 9
+        exists, then it is an integer from 1 to 9 (DOSE_NUMBER_MAX_VALUE)
         """
         field_location = "protocolApplied[0].doseNumberPositiveInt"
         try:
             field_value = values["protocolApplied"][0]["doseNumberPositiveInt"]
-            PreValidation.for_positive_integer(field_value, field_location)
+            PreValidation.for_positive_integer(field_value, field_location, self.DOSE_NUMBER_MAX_VALUE)
         except (KeyError, IndexError):
             pass
 

backend/tests/test_immunization_pre_validator.py

@@ -25,6 +25,7 @@
 from utils.pre_validation_test_utils import ValidatorModelTests
 from utils.values_for_tests import ValidValues, InvalidValues
 from models.constants import Constants
+from models.fhir_immunization_pre_validators import PreValidators
 
 class TestImmunizationModelPreValidationRules(unittest.TestCase):
     """Test immunization pre validation rules on the FHIR model using the covid sample data"""
@@ -819,6 +820,33 @@ def test_pre_validate_protocol_applied(self):
         )
 
     def test_pre_validate_protocol_applied_dose_number_positive_int(self):
+        """
+        Test pre_validate_protocol_applied_dose_number_positive_int accepts valid values and
+        rejects invalid values
+        """
+        for value in range(1, PreValidators.DOSE_NUMBER_MAX_VALUE + 1):
+            data = {
+                "protocolApplied": [
+                    {"doseNumberPositiveInt": value}
+                ]
+            }
+            validator = PreValidators(data)
+            # Should not raise
+            validator.pre_validate_dose_number_positive_int(data)
+
+    def test_out_of_range_dose_number(self):
+        # Invalid: doseNumberPositiveInt < 1 or > 9
+        for value in [0, PreValidators.DOSE_NUMBER_MAX_VALUE + 1, -1]:
+            data = {
+                "protocolApplied": [
+                    {"doseNumberPositiveInt": value}
+                ]
+            }
+            validator = PreValidators(data)
+            with self.assertRaises(ValueError):
+                validator.pre_validate_dose_number_positive_int(data)
+
+    def test_test_positive_integer_value(self):
         """
         Test pre_validate_protocol_applied_dose_number_positive_int accepts valid values and
         rejects invalid values