Unit test coverage

Author: robertnovac1

filenameprocessor/tests/test_lambda_handler.py

@@ -466,6 +466,30 @@ def setUp(self):
     def tearDown(self):
         GenericTearDown(s3_client, firehose_client, sqs_client, dynamodb_client)
 
+    def test_elasticcache_failure_handled(self):
+        event = {
+            "s3": {
+                "bucket": {"name": "my-config-bucket"},  # triggers 'config' branch
+                "object": {"key": "testfile.csv"}
+            }
+        }
+
+        with patch("file_name_processor.upload_to_elasticache", side_effect=Exception("Upload failed")), \
+             patch("file_name_processor.logger") as mock_logger:
+
+            result = handle_record(event)
+
+            self.assertEqual(result["statusCode"], 500)
+            self.assertEqual(result["message"], "Failed to upload file content to cache")
+            self.assertEqual(result["file_key"], "testfile.csv")
+            self.assertIn("error", result)
+            self.assertEqual(result["vaccine_type"], "unknown")
+            self.assertEqual(result["supplier"], "unknown")
+
+            mock_logger.error.assert_called_once()
+            logged_msg = mock_logger.error.call_args[0][0]
+            self.assertIn("Error uploading to cache", logged_msg)
+
     def test_successful_processing_from_configs(self):
         """Tests that the permissions config file content is uploaded to elasticache successfully"""
         fake_redis = fakeredis.FakeStrictRedis()
@@ -538,7 +562,46 @@ def test_successful_processing_from_configs(self):
         self.assertEqual(result, expected_result)
 
 
+@patch.dict("os.environ", MOCK_ENVIRONMENT_DICT)
+@mock_s3
+@mock_dynamodb
+@mock_sqs
+@mock_firehose
+class TestUnexpectedBucket(TestCase):
+    """Tests for lambda_handler when an unexpected bucket name is used"""
+
+    def setUp(self):
+        GenericSetUp(s3_client, firehose_client, sqs_client, dynamodb_client)
+
+    def tearDown(self):
+        GenericTearDown(s3_client, firehose_client, sqs_client, dynamodb_client)
+
+    def test_unexpected_bucket_name(self):
+        record = {
+            "s3": {
+                "bucket": {"name": "unknown-bucket"},
+                "object": {"key": "somefile.csv"}
+            }
+        }
+
+        with patch("file_name_processor.logger") as mock_logger:
+            result = handle_record(record)
+
+            self.assertEqual(result["statusCode"], 500)
+            self.assertIn("unexpected bucket name", result["message"])
+            self.assertEqual(result["file_key"], "somefile.csv")
+            self.assertEqual(result["vaccine_type"], "unknown")
+            self.assertEqual(result["supplier"], "unknown")
+
+            mock_logger.error.assert_called_once()
+            args = mock_logger.error.call_args[0]
+            self.assertIn("Unable to process file", args[0])
+            self.assertIn("somefile.csv", args)
+            self.assertIn("unknown-bucket", args)
+
+
 class TestMainEntryPoint(TestCase):
+
     def test_run_local_constructs_event_and_calls_lambda_handler(self):
         test_args = [
             "file_name_processor.py",