testing all fields

Author: Akol125

backend/src/models/utils/pre_validator_utils.py

@@ -98,7 +98,7 @@ def for_date(field_value: str, field_location: str, future_date_allowed: bool =
                 f'{field_location} must be a valid date string in the format "YYYY-MM-DD"'
             ) from value_error
 
-        # Enforce not-in-the-future rule using central checker (after successful parse)
+        # Enforce future date rule using central checker after successful parse
         if not future_date_allowed and PreValidation.check_if_future_date(parsed_date):
             raise ValueError(f"{field_location} must not be in the future")
 
@@ -140,7 +140,7 @@ def for_date_time(field_value: str, field_location: str, strict_timezone: bool =
         for fmt in formats:
             try:
                 fhir_date = datetime.strptime(field_value, fmt)
-                # Enforce future-date rule using central checker (after successful parse)
+                # Enforce future-date rule using central checker after successful parse
                 if PreValidation.check_if_future_date(fhir_date):
                     raise ValueError(f"{field_location} must not be in the future")
                 # After successful parse, enforce timezone and future-date rules
@@ -255,4 +255,5 @@ def check_if_future_date(parsed_value: date | datetime):
         elif isinstance(parsed_value, date):
             now = datetime.now().date()
         if parsed_value > now:
-            return True
+            return True
+        return False

backend/tests/utils/values_for_tests.py

@@ -34,7 +34,7 @@ class ValidValues:
     for_date_times_strict_timezones = [
         "2000-01-01",  # Full date only
         "2000-01-01T00:00:00+00:00",  # Time and offset all zeroes
-        "2025-05-20T18:26:30+01:00",  # Date with Time with no milliseconds and positive offset
+        "2025-09-24T11:04:30+01:00",  # Date with Time with no milliseconds and positive offset
         "2000-01-01T00:00:00+01:00",  # Time and offset all zeroes
         "1933-12-31T11:11:11+01:00",  # Positive offset (with hours and minutes not 0)
         "1933-12-31T11:11:11.1+00:00",  # DateTime with milliseconds to 1 decimal place