review fixes

Author: JamesW1-NHS

filenameprocessor/src/file_name_processor.py

@@ -73,7 +73,7 @@ def handle_record(record) -> dict:
             message_id, file_key, created_at_formatted_string, expiry_timestamp, queue_name, FileStatus.QUEUED
         )
         make_and_send_sqs_message(
-            file_key, message_id, permissions, vaccine_type, supplier, created_at_formatted_string, expiry_timestamp
+            file_key, message_id, permissions, vaccine_type, supplier, created_at_formatted_string
         )
 
         logger.info("Lambda invocation successful for file '%s'", file_key)

filenameprocessor/src/send_sqs_message.py

@@ -32,8 +32,7 @@ def make_and_send_sqs_message(
     permission: list[str],
     vaccine_type: str,
     supplier: str,
-    created_at_formatted_string: str,
-    expires_at: int
+    created_at_formatted_string: str
 ) -> None:
     """Attempts to send a message to the SQS queue. Raises an exception if the message is not successfully sent."""
     message_body = {
@@ -43,7 +42,6 @@ def make_and_send_sqs_message(
         "filename": file_key,
         "permission": permission,
         "created_at_formatted_string": created_at_formatted_string,
-        "expires_at": expires_at,
     }
 
     send_to_supplier_queue(message_body, vaccine_type, supplier)

filenameprocessor/tests/utils_for_tests/values_for_tests.py

@@ -34,7 +34,7 @@ def __init__(self, supplier: str, vaccine_type: str, ods_code: str, file_number:
         self.queue_name = f"{self.supplier}_{self.vaccine_type}"
 
         self.created_at_formatted_string = f"200{file_number}0101T00000000"
-        self.expires_at = 947808000
+        self.expires_at = MOCK_EXPIRES_AT
         self.message_id = f"{self.supplier}_{self.vaccine_type}_test_id_{file_number}"
         self.name = f"{self.vaccine_type}/ {self.supplier} file"
 

terraform/file_name_processor.tf

@@ -283,7 +283,7 @@ resource "aws_lambda_function" "file_processor_lambda" {
       REDIS_PORT                 = data.aws_elasticache_cluster.existing_redis.cache_nodes[0].port
       SPLUNK_FIREHOSE_NAME       = module.splunk.firehose_stream_name
       AUDIT_TABLE_NAME           = aws_dynamodb_table.audit-table.name
-      AUDIT_TABLE_TTF_DAYS       = 60
+      AUDIT_TABLE_TTL_DAYS       = 60
     }
   }
   kms_key_arn                    = data.aws_kms_key.existing_lambda_encryption_key.arn