tidy

Author: nhsdevws

lambdas/id_sync/src/ieds_db_operations.py

@@ -18,19 +18,13 @@ def get_ieds_table():
 
 def ieds_check_exist(id: str) -> bool:
     """Check if a record exists in the IEDS table for the given ID."""
-    logger.info(f"ieds_check_exist. Get ID: {id}")
-    search_patient_pk = f"Patient#{id}"
+    logger.info(f"Check Id exists ID: {id}")
+    items = get_items_from_patient_id(id, 1)
 
-    response = get_ieds_table().query(
-        IndexName='PatientGSI',
-        KeyConditionExpression=Key('PatientPK').eq(search_patient_pk),
-        Limit=1
-    )
-
-    items = response.get('Items', [])
-    found = len(items) > 0
-    logger.info(f"ieds_check_exist. Record found: {found} for ID: {id}")
-    return found
+    if items or len(items) > 0:
+        logger.info(f"Found patient ID: {id}")
+        return True
+    return False
 
 
 BATCH_SIZE = 25
@@ -49,10 +43,9 @@ def ieds_update_patient_id(old_id: str, new_id: str) -> dict:
         logger.info(f"Updating patient ID in IEDS from {old_id} to {new_id}")
 
         new_patient_pk = f"Patient#{new_id}"
-        old_patient_pk = f"Patient#{old_id}"
 
         logger.info("Getting items to update in IEDS table...")
-        items_to_update = get_items_from_patient_pk(old_patient_pk)
+        items_to_update = get_items_from_patient_id(old_id)
 
         if not items_to_update:
             logger.warning(f"No items found to update for patient ID: {old_id}")
@@ -63,12 +56,9 @@ def ieds_update_patient_id(old_id: str, new_id: str) -> dict:
 
         transact_items = []
 
-        logger.info("loop through items to update...")
         logger.info(f"Items to update: {len(items_to_update)}")
         ieds_table_name = get_ieds_table_name()
         for item in items_to_update:
-            logger.info("Update item")
-            logger.info(f"Updating item: {item['PatientPK']}")
             transact_items.append({
                 'Update': {
                     'TableName': ieds_table_name,
@@ -147,14 +137,15 @@ def ieds_update_patient_id(old_id: str, new_id: str) -> dict:
 #     return result
 
 
-def get_items_from_patient_pk(patient_pk: str) -> list:
-    """Get all items for patient PK."""
-    logger.info(f"Getting items for patient PK: {patient_pk}")
+def get_items_from_patient_id(id: str, limit=BATCH_SIZE) -> list:
+    """Get all items for patient ID."""
+    logger.info(f"Getting items for patient id: {id}")
+    patient_pk = f"Patient#{id}"
     try:
         response = get_ieds_table().query(
             IndexName='PatientGSI',  # query the GSI
             KeyConditionExpression=Key('PatientPK').eq(patient_pk),
-            Limit=BATCH_SIZE
+            Limit=limit
         )
 
         if 'Items' not in response or not response['Items']: