Test

Author: nhsdevws

delta_backend/tests/test_convert_to_flat_json.py

@@ -1116,4 +1116,4 @@ def _run_test_practitioner_surname(self, expected_forename):
         self.assertEqual(flat_json[0]["PERFORMING_PROFESSIONAL_SURNAME"], expected_forename)
 
     if __name__ == "__main__":
-        unittest.main()
+        unittest.main()

delta_backend/tests/test_log_firehose.py

@@ -45,5 +45,29 @@ def test_send_log(self, mock_boto_client):
         # Assert that the return value is as expected (optional)
         self.assertEqual(mock_firehose_client.put_record.return_value, mock_response)
 
+        @patch("boto3.client")  # Mock boto3.client
+        def test_send_log_failure(self, mock_boto_client):
+            """Test that send_log logs an exception when put_record fails."""
+            # Arrange
+            mock_firehose_client = MagicMock()
+            mock_boto_client.return_value = mock_firehose_client
+            mock_firehose_client.put_record.side_effect = Exception("Test exception")
+
+            stream_name = "test-stream"
+            firehose_logger = FirehoseLogger(boto_client=mock_firehose_client, stream_name=stream_name)
+            log_message = {"key": "value"}
+
+            # Mock logger.exception
+            with patch("src.log_firehose.logger.exception") as mock_logger_exception:
+                # Act
+                firehose_logger.send_log(log_message)
+
+                # Assert
+                mock_firehose_client.put_record.assert_called_once_with(
+                    DeliveryStreamName="test-stream",
+                    Record={"Data": json.dumps(log_message).encode("utf-8")},
+                )
+                mock_logger_exception.assert_called_once_with("Error sending log to Firehose: Test exception")
+
 if __name__ == "__main__":
     unittest.main()