Good Tests

Author: nhsdevws

delta_backend/src/delta.py

@@ -28,7 +28,7 @@ def send_message(record):
         sqs_client.send_message(QueueUrl=failure_queue_url, MessageBody=json.dumps(message_body))
         logger.info("Record saved successfully to the DLQ")
     except ClientError as e:
-        logger.info(f"Error sending record to DLQ: {e}")
+        logger.error(f"Error sending record to DLQ: {e}")
 
 
 def get_vaccine_type(patientsk) -> str:

delta_backend/src/log_firehose.py

@@ -12,26 +12,17 @@
 class FirehoseLogger:
     def __init__(
         self,
-        # @SW: SPLUNK_FIREHOSE_NAME doesnt seem to be defined in the Sonorcloud environment
-        stream_name: str = os.getenv("SPLUNK_FIREHOSE_NAME", "AAA"),
-        boto_client=None,
+        stream_name: str = os.getenv("SPLUNK_FIREHOSE_NAME"),
+        boto_client=boto3.client("firehose", config=Config(region_name="eu-west-2")),
     ):
-        logger.info(">>>>>>FirehoseLogger.init DUMP ENV VARIABLES!!!")
-        if boto_client is None:
-            boto_client = boto3.client("firehose", config=Config(region_name="eu-west-2"))
         self.firehose_client = boto_client
         self.delivery_stream_name = stream_name
-        logger.info(f">>>>>> Firehose stream name: {stream_name}")
-        for key, value in os.environ.items():
-            logger.info(f">>> VAR: {key}: {value}")
-
 
     def send_log(self, log_message):
         log_to_splunk = log_message
         logger.info(f"Log sent to Firehose for save: {log_to_splunk}")
         encoded_log_data = json.dumps(log_to_splunk).encode("utf-8")
         try:
-            logger.info(f"Send log to Firehose")
             response = self.firehose_client.put_record(
                 DeliveryStreamName=self.delivery_stream_name,
                 Record={"Data": encoded_log_data},