remove copy check, some comments

Author: JamesW1-NHS

lambdas/shared/src/common/aws_s3_utils.py

@@ -43,9 +43,4 @@ def delete_file(
         Bucket=source_bucket,
         Key=source_key,
         ExpectedBucketOwner=expected_bucket_owner,
-    )
-
-
-def is_file_in_bucket(bucket_name: str, file_key: str) -> None:
-    s3_client = get_s3_client()
-    s3_client.head_object(Bucket=bucket_name, Key=file_key)
+    )

lambdas/shared/tests/test_common/test_s3_utils.py

@@ -4,7 +4,6 @@
 from unittest.mock import patch
 
 import boto3
-from botocore.exceptions import ClientError
 from moto import mock_aws
 
 from common import aws_s3_utils
@@ -117,45 +116,3 @@ def test_move_file_outside_bucket_copies_then_deletes(self):
         # Assert source object was deleted
         with self.assertRaises(self.s3.exceptions.NoSuchKey):
             self.s3.get_object(Bucket=self.source_bucket, Key=source_key)
-
-    def test_is_file_in_bucket(self):
-        """File should be present in destination bucket"""
-        file_key = "src/move_file_test.csv"
-
-        # Put an object in the source bucket
-        body_content = b"dummy file content"
-        self.s3.put_object(Bucket=self.source_bucket, Key=file_key, Body=body_content)
-
-        # Should raise no exception
-        aws_s3_utils.is_file_in_bucket(
-            bucket_name=self.source_bucket,
-            file_key=file_key,
-        )
-
-    def test_is_file_not_in_bucket(self):
-        """File should not be present in source bucket"""
-        file_key = "src/move_file_test.csv"
-
-        # Don't put the object in the source bucket
-
-        # Should raise an exception
-        with self.assertRaises(ClientError):
-            aws_s3_utils.is_file_in_bucket(
-                bucket_name=self.source_bucket,
-                file_key=file_key,
-            )
-
-    def test_is_file_in_wrong_bucket(self):
-        """File should not be present in destination bucket"""
-        file_key = "src/move_file_test.csv"
-
-        # Put an object in the source bucket
-        body_content = b"dummy file content"
-        self.s3.put_object(Bucket=self.source_bucket, Key=file_key, Body=body_content)
-
-        # Should raise an exception
-        with self.assertRaises(ClientError):
-            aws_s3_utils.is_file_in_bucket(
-                bucket_name=self.destination_bucket,
-                file_key=file_key,
-            )