Remove old linting code. Add Terraform to tool versions file. (#897)

* Remove old linting code. Add Terraform to tool versions file for asdf / mise users.

* Update quality checks pipeline.

* Update dist included files.

* Remove unnecessary pipeline step and template.

* Reinstate .terraform-version while we're still using APIM pipelines.

Author: mfjarvis

.flake8

@@ -25,7 +25,7 @@ jobs:
           cache: "npm"
 
       - name: Install linting dependencies
-        run: make install-node
+        run: make install
 
       - name: Lint
         run: make lint

.github/workflows/quality-checks.yml

@@ -1,3 +1,4 @@
 poetry 2.1.4
 nodejs 23.11.0
 python 3.11.12
+terraform 1.12.2

.tool-versions

@@ -3,20 +3,12 @@ SHELL=/usr/bin/env bash -euo pipefail
 PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS = backend batch_processor_filter delta_backend filenameprocessor mesh_processor recordprocessor lambdas/ack_backend lambdas/redis_sync lambdas/id_sync lambdas/mns_subscription lambdas/shared
 PYTHON_PROJECT_DIRS = e2e e2e_batch quality_checks $(PYTHON_PROJECT_DIRS_WITH_UNIT_TESTS)
 
-.PHONY: install-python install-node install lint format format-check clean publish build-proxy release initialise-all-python-venvs update-all-python-dependencies run-all-python-unit-tests build-all-docker-images
-
-#Installs dependencies using poetry.
-install-python:
-	poetry lock --no-update
-	poetry install
+.PHONY: install lint format format-check clean publish build-proxy release initialise-all-python-venvs update-all-python-dependencies run-all-python-unit-tests build-all-docker-images
 
 #Installs dependencies using npm.
-install-node:
+install:
 	npm install --legacy-peer-deps
 
-#Condensed Target to run all targets above.
-install: install-node install-python
-
 #Run the npm linting script (specified in package.json). Used to check the syntax and formatting of files.
 lint:
 	npm run lint
@@ -45,7 +37,7 @@ build-proxy:
 
 #Files to loop over in release
 # VED-811: remove everything except for proxy related files as we move to Github Actions for backend deployment
-_dist_include="pytest.ini poetry.lock poetry.toml pyproject.toml Makefile build/. specification sandbox terraform scripts"
+_dist_include="poetry.toml Makefile build/. specification sandbox terraform scripts"
 
 #Create /dist/ sub-directory and copy files into directory
 #Ensure full dir structure is preserved for Lambdas

Makefile

@@ -28,12 +28,6 @@ steps:
             - ptl/app-credentials/immunisation-fhir-api-testing-app/non-prod/INT_CLIENT_ID
             - ptl/app-credentials/immunisation-fhir-api-testing-app/non-prod/INT_CLIENT_SECRET
 
-  - bash: |
-      make install-python
-    workingDirectory: $(Pipeline.Workspace)/s/$(SERVICE_NAME)/$(SERVICE_ARTIFACT_NAME)
-    displayName: Setup pytests
-    condition: always()
-
   - template: ./aws-assume-role.yml
     parameters:
       role: "auto-ops"