tidy

Author: nhsdevws

backend/src/constants.py

@@ -23,3 +23,5 @@ class Urls:
 
 
 GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE = "Unable to process request. Issue may be transient."
+
+VACCINE_TYPE_TO_DISEASES_HASH_KEY = "vacc_to_diseases"

backend/src/parameter_parser.py

@@ -8,6 +8,7 @@
 
 from clients import redis_client
 from models.errors import ParameterException
+from constants import VACCINE_TYPE_TO_DISEASES_HASH_KEY
 
 ParamValue = list[str]
 ParamContainer = dict[str, ParamValue]
@@ -108,7 +109,7 @@ def process_search_params(params: ParamContainer) -> SearchParams:
     if len(vaccine_types) < 1:
         raise ParameterException(f"Search parameter {immunization_target_key} must have one or more values.")
 
-    valid_vaccine_types = redis_client.hkeys("vacc_to_diseases")
+    valid_vaccine_types = redis_client.hkeys(VACCINE_TYPE_TO_DISEASES_HASH_KEY)
     if any([x not in valid_vaccine_types for x in vaccine_types]):
         raise ParameterException(
             f"immunization-target must be one or more of the following: {', '.join(valid_vaccine_types)}")