reverting some changes

Author: Akol125

lambdas/id_sync/src/id_sync.py

@@ -24,9 +24,6 @@ def handler(event_data: Dict[str, Any], _context) -> Dict[str, Any]:
 
         logger.info("id_sync processing event with %d records", len(records))
 
-        # Use explicit loops instead of list comprehensions so we can more
-        # easily inspect intermediate results and avoid building temporary
-        # comprehension constructs.
         results = []
         nhs_numbers = []
         error_count = 0

lambdas/id_sync/src/ieds_db_operations.py

@@ -22,7 +22,7 @@ def get_ieds_table():
 
 
 def ieds_update_patient_id(old_id: str, new_id: str, items_to_update: list | None = None) -> dict:
-    """Update the patient ID in the IEDS table."""
+    """Update the patient ID (new NHS number) in the IEDS table."""
     logger.info(f"ieds_update_patient_id. Update patient ID from {old_id} to {new_id}")
     if not old_id or not new_id or not old_id.strip() or not new_id.strip():
         return make_status("Old ID and New ID cannot be empty", old_id, "error")

lambdas/id_sync/src/pds_details.py

@@ -43,7 +43,6 @@ def pds_get_patient_id(nhs_number: str) -> str:
     :return: PDS patient ID
     """
     try:
-        logger.info(f"get_pds_patient_id. nhs_number: {nhs_number}")
         patient_details = pds_get_patient_details(nhs_number)
         if not patient_details:
             return None

lambdas/id_sync/src/record_processor.py

@@ -69,18 +69,15 @@ def process_nhs_number(nhs_number: str) -> Dict[str, Any]:
     # Compare demographics from PDS to each IEDS item, keep only matching records
     matching_records = []
     discarded_count = 0
-    discarded_records = []
     for detail in ieds_resources:
         logger.info("Processing IEDS record: %s", detail)
         if demographics_match(pds_patient_resource, detail):
             matching_records.append(detail)
         else:
             discarded_count += 1
-            discarded_records.append(detail)
 
     if not matching_records:
-        logger.info("No records matched PDS demographics: %d\nDiscarded:\n%s", discarded_count,
-                    json.dumps(discarded_records, indent=2), default=str)
+        logger.info("No records matched PDS demographics: %d", discarded_count,)
         return make_status("No records matched PDS demographics; update skipped", nhs_number)
 
     response = ieds_update_patient_id(

lambdas/shared/src/common/clients.py

@@ -2,19 +2,9 @@
 import logging
 from boto3 import client as boto3_client, resource as boto3_resource
 
+logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger()
-logger.setLevel(logging.INFO)  # Root logger level
-
-if logger.hasHandlers():
-    logger.handlers.clear()
-
-console = logging.StreamHandler()
-console.setLevel(logging.INFO)  # Handler must also allow INFO logs
-
-formatter = logging.Formatter('%(asctime)s - %(levelname)s - %(message)s')
-console.setFormatter(formatter)
-
-logger.addHandler(console)
+logger.setLevel(logging.INFO)
 
 STREAM_NAME = os.getenv("SPLUNK_FIREHOSE_NAME", "firehose-name-not-defined")
 CONFIG_BUCKET_NAME = os.getenv("CONFIG_BUCKET_NAME", "variconfig-bucketable-not-defined")

lambdas/shared/tests/test_common/test_clients.py

@@ -58,4 +58,4 @@ def test_logger_is_initialized(self):
 
     def test_logger_set_level(self):
         """Test that logger level is set to INFO"""
-        self.mock_logger_instance.setLevel.assert_called_once_with(logging.INFO)
+        self.mock_logger_instance.setLevel.assert_called_once_with(logging.INFO)