coverage fuge

Author: nhsdevws

lambdas/shared/src/common/aws_lambda_event.py

@@ -13,7 +13,12 @@ class AwsEventType(Enum):
 
 class AwsLambdaEvent:
 
-    def __init__(self, event: Dict[str, Any]):
+    def __init__(self):
+        self.event_source = None
+        self.records = []
+        self.event_type = AwsEventType.UNKNOWN
+
+    def load_event(self, event: Dict[str, Any]) -> None:
         self.event_source = event.get('eventSource')
         if self.event_source in [e.value for e in AwsEventType]:
             self.event_type = AwsEventType(self.event_source)

lambdas/shared/tests/test_common/test_aws_lambda_event.py

@@ -51,7 +51,8 @@ def test_init_with_sqs_event(self):
             'eventSource': 'aws:sqs'
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.SQS)
         self.assertEqual(len(lambda_event.records), 1)
@@ -65,7 +66,8 @@ def test_init_with_s3_event(self):
             'eventSource': 'aws:s3'
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.S3)
         self.assertEqual(len(lambda_event.records), 1)
@@ -79,7 +81,8 @@ def test_init_with_sns_event(self):
             'eventSource': 'aws:sns'
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.SNS)
         self.assertEqual(len(lambda_event.records), 1)
@@ -96,7 +99,8 @@ def test_init_with_multiple_sqs_records(self):
             'eventSource': 'aws:sqs'
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.SQS)
         self.assertEqual(len(lambda_event.records), 2)
@@ -111,7 +115,8 @@ def test_init_with_empty_records(self):
             'Records': []
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.UNKNOWN)
         self.assertEqual(len(lambda_event.records), 0)
@@ -123,7 +128,8 @@ def test_init_without_records(self, mock_logger):
             'some_other_key': 'value'
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.UNKNOWN)
         self.assertEqual(len(lambda_event.records), 0)
@@ -135,7 +141,8 @@ def test_init_with_top_level_event_source(self):
             'Records': [self.s3_record_dict]
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.S3)
 
@@ -150,7 +157,8 @@ def test_init_with_unknown_event_source(self, mock_logger):
             'Records': [unknown_record]
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.UNKNOWN)
         self.assertEqual(len(lambda_event.records), 1)
@@ -165,7 +173,8 @@ def test_init_with_missing_event_source(self):
             'Records': [record_without_source]
         }
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.UNKNOWN)
 
@@ -181,7 +190,8 @@ def test_mixed_multiple_records(self):
         mixed_records = [self.sqs_record_dict, self.s3_record_dict]
         event = {'Records': mixed_records, 'eventSource': 'aws:sqs'}
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.SQS)
         self.assertEqual(len(lambda_event.records), 2)
@@ -190,7 +200,8 @@ def test_empty_records(self):
         """Test empty records"""
         event = {'Records': []}
 
-        lambda_event = AwsLambdaEvent(event)
+        lambda_event = AwsLambdaEvent()
+        lambda_event.load_event(event)
 
         self.assertEqual(lambda_event.event_type, AwsEventType.UNKNOWN)
         self.assertEqual(len(lambda_event.records), 0)