resolve review comment on adding more scenarios for fhir

Author: Akol125

lambdas/shared/src/common/validator/parsers/schema_parser.py

@@ -25,7 +25,7 @@ def __init__(self) -> None:
         self.schema_file = {}
         self.expressions = {}
 
-    def parse_schema(self, schema_file: dict) -> dict:
+    def parse_schema(self, schema_file: dict) -> "SchemaParser":
         """
         Loads a schema definition (JSON/dict) and extracts expressions.
         """

lambdas/shared/tests/test_common/validator/test_application_fhir.py

@@ -14,16 +14,15 @@ def setUp(self):
         validation_folder = Path(__file__).resolve().parent
         self.FHIRFilePath = validation_folder / "sample_data/vaccination.json"
         self.schemaFilePath = validation_folder / "test_schemas/test_schema.json"
+        self.SchemaFile = parse_test_file(self.schemaFilePath)
+        self.fhir_resources = parse_test_file(self.FHIRFilePath)
 
     def test_fhir_validation(self):
         start = time.time()
-
-        SchemaFile = parse_test_file(self.schemaFilePath)
-        self.fhir_resources = parse_test_file(self.FHIRFilePath)
         fhir_parser = Mock()
         fhir_parser.extract_field_value.return_value = "2025-11-06T12:00:00Z"
 
-        validator = Validator(SchemaFile)
+        validator = Validator(self.SchemaFile)
         error_list = validator.validate_fhir(self.fhir_resources, True, True, True)
         error_report = build_error_report(
             "25a8cc4d-1875-4191-ac6d-2d63a0ebc64b", fhir_parser, error_list
@@ -45,3 +44,16 @@ def test_fhir_validation(self):
         end = time.time()
         print("Time Taken : ")
         print(end - start)
+
+    def test_fhir_validation_fail(self):
+        """Test validation failure when a required field is missing or invalid."""
+        # Create an invalid FHIR resource by removing a required key
+        self.fhir_resources["contained"][0]["identifier"][0]["value"] = ""
+
+        fhir_parser = Mock()
+        fhir_parser.extract_field_value.return_value = None
+
+        validator = Validator(self.SchemaFile)
+        error_list = validator.validate_fhir(self.fhir_resources, True, True, True)
+        self.assertGreater(len(error_list), 0, "Expected at least one validation error")
+        self.assertTrue(validator.has_validation_failed(error_list))