Switch to Ruff for Python linting and formatting. (#898)

* Remove old linting code. Add Terraform to tool versions file for asdf / mise users.

* Update quality checks pipeline.

* Update dist included files.

* Remove unnecessary pipeline step and template.

* Reinstate .terraform-version while we're still using APIM pipelines.

* Switch to Ruff for Python linting and formatting.

* Auto apply safe fixes on commit.

* Attempt to fix first-party import detection.

* Revert failed attempt. Specify target Python version and apply automatic fixes.

Author: mfjarvis

backend/src/authorisation/authoriser.py

@@ -3,7 +3,7 @@
 import json
 
 from authorisation.api_operation_code import ApiOperationCode
-from clients import redis_client, logger
+from clients import logger, redis_client
 from constants import SUPPLIER_PERMISSIONS_HASH_KEY
 
 

backend/src/base_utils/base_utils.py

@@ -1,10 +1,8 @@
 """Utils for backend src code"""
 
 from models.field_locations import FieldLocations
-
 from models.obtain_field_value import ObtainFieldValue
 
-
 FIELD_LOCATIONS = FieldLocations()
 
 

backend/src/create_imms_handler.py

@@ -3,12 +3,11 @@
 import pprint
 import uuid
 
-
+from constants import GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE
 from fhir_controller import FhirController, make_controller
 from local_lambda import load_string
-from models.errors import Severity, Code, create_operation_outcome
 from log_structure import function_info
-from constants import GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE
+from models.errors import Code, Severity, create_operation_outcome
 
 logging.basicConfig(level="INFO")
 logger = logging.getLogger()

backend/src/delete_imms_handler.py

@@ -3,11 +3,10 @@
 import pprint
 import uuid
 
-
+from constants import GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE
 from fhir_controller import FhirController, make_controller
-from models.errors import Severity, Code, create_operation_outcome
 from log_structure import function_info
-from constants import GENERIC_SERVER_ERROR_DIAGNOSTICS_MESSAGE
+from models.errors import Code, Severity, create_operation_outcome
 
 logging.basicConfig(level="INFO")
 logger = logging.getLogger()

backend/src/fhir_batch_controller.py

@@ -1,7 +1,7 @@
 """Function to send the request directly to lambda (or return appropriate diagnostics if this is not possible)"""
 
-from fhir_batch_service import ImmunizationBatchService
 from fhir_batch_repository import ImmunizationBatchRepository
+from fhir_batch_service import ImmunizationBatchService
 
 
 def make_batch_controller():

backend/src/fhir_batch_repository.py

@@ -1,13 +1,14 @@
 import os
+import time
 import uuid
+from dataclasses import dataclass
+
 import boto3
-import time
+import botocore.exceptions
 import simplejson as json
+from boto3.dynamodb.conditions import Attr, Key
 from clients import logger
-from dataclasses import dataclass
-import botocore.exceptions
-from boto3.dynamodb.conditions import Key, Attr
-from models.errors import UnhandledResponseError, IdentifierDuplicationError, ResourceNotFoundError, ResourceFoundError
+from models.errors import IdentifierDuplicationError, ResourceFoundError, ResourceNotFoundError, UnhandledResponseError
 
 
 def create_table(region_name="eu-west-2"):

backend/src/fhir_batch_service.py

@@ -1,8 +1,7 @@
-from pydantic import ValidationError
 from fhir_batch_repository import ImmunizationBatchRepository
-from models.errors import CustomValidationError
+from models.errors import CustomValidationError, MandatoryError
 from models.fhir_immunization import ImmunizationValidator
-from models.errors import MandatoryError
+from pydantic import ValidationError
 
 
 class ImmunizationBatchService:

backend/src/fhir_controller.py

@@ -2,30 +2,30 @@
 import json
 import os
 import re
+import urllib.parse
 import uuid
 from decimal import Decimal
 from typing import Optional
+
 from aws_lambda_typing.events import APIGatewayProxyEventV1
-from fhir.resources.R4B.immunization import Immunization
 from boto3 import client as boto3_client
-
+from fhir.resources.R4B.immunization import Immunization
 from fhir_repository import ImmunizationRepository, create_table
 from fhir_service import FhirService, UpdateOutcome, get_service_url
 from models.errors import (
-    Severity,
     Code,
-    create_operation_outcome,
-    UnauthorizedError,
-    ResourceNotFoundError,
-    UnhandledResponseError,
-    ValidationError,
     IdentifierDuplicationError,
     ParameterException,
+    ResourceNotFoundError,
+    Severity,
+    UnauthorizedError,
     UnauthorizedVaxError,
+    UnhandledResponseError,
+    ValidationError,
+    create_operation_outcome,
 )
 from models.utils.generic_utils import check_keys_in_sources
-from parameter_parser import process_params, process_search_params, create_query_string
-import urllib.parse
+from parameter_parser import create_query_string, process_params, process_search_params
 
 sqs_client = boto3_client("sqs", region_name="eu-west-2")
 queue_url = os.getenv("SQS_QUEUE_URL", "Queue_url")

backend/src/fhir_repository.py

@@ -9,18 +9,17 @@
 import simplejson as json
 from boto3.dynamodb.conditions import Attr, Key
 from botocore.config import Config
-from mypy_boto3_dynamodb.service_resource import DynamoDBServiceResource, Table
-from responses import logger
-
 from models.errors import (
+    IdentifierDuplicationError,
     ResourceNotFoundError,
     UnhandledResponseError,
-    IdentifierDuplicationError,
 )
 from models.utils.validation_utils import (
-    get_vaccine_type,
     check_identifier_system_value,
+    get_vaccine_type,
 )
+from mypy_boto3_dynamodb.service_resource import DynamoDBServiceResource, Table
+from responses import logger
 
 
 def create_table(table_name=None, endpoint_url=None, region_name="eu-west-2"):

backend/src/fhir_service.py

@@ -1,36 +1,42 @@
-import logging
-from uuid import uuid4
 import datetime
+import logging
 import os
 from enum import Enum
 from typing import Optional, Union
+from uuid import uuid4
 
+import parameter_parser
+from authorisation.api_operation_code import ApiOperationCode
+from authorisation.authoriser import Authoriser
 from fhir.resources.R4B.bundle import (
     Bundle as FhirBundle,
+)
+from fhir.resources.R4B.bundle import (
     BundleEntry,
-    BundleLink,
     BundleEntrySearch,
+    BundleLink,
 )
 from fhir.resources.R4B.immunization import Immunization
-from pydantic import ValidationError
-
-import parameter_parser
-from authorisation.api_operation_code import ApiOperationCode
-from authorisation.authoriser import Authoriser
 from fhir_repository import ImmunizationRepository
-from models.errors import InvalidPatientId, CustomValidationError, UnauthorizedVaxError, ResourceNotFoundError
+from filter import Filter
+from models.errors import (
+    CustomValidationError,
+    InvalidPatientId,
+    MandatoryError,
+    ResourceNotFoundError,
+    UnauthorizedVaxError,
+)
 from models.fhir_immunization import ImmunizationValidator
 from models.utils.generic_utils import (
-    nhs_number_mod11_check,
-    get_occurrence_datetime,
     create_diagnostics,
     form_json,
     get_contained_patient,
+    get_occurrence_datetime,
+    nhs_number_mod11_check,
 )
-from models.errors import MandatoryError
 from models.utils.validation_utils import get_vaccine_type
+from pydantic import ValidationError
 from timer import timed
-from filter import Filter
 
 logging.basicConfig(level="INFO")
 logger = logging.getLogger()
@@ -39,7 +45,6 @@
 def get_service_url(
     service_env: str = os.getenv("IMMUNIZATION_ENV"), service_base_path: str = os.getenv("IMMUNIZATION_BASE_PATH")
 ) -> str:
-
     if not service_base_path:
         service_base_path = "immunisation-fhir-api/FHIR/R4"