Sonar and attempt to fix tf apply in pipeline

Author: dlzhry2nhs

backend/src/service/fhir_service.py

@@ -148,7 +148,6 @@ def create_immunization(self, immunization: dict, supplier_system: str) -> str:
         if not self.authoriser.authorise(supplier_system, ApiOperationCode.CREATE, {vaccination_type}):
             raise UnauthorizedVaxError()
 
-        # TODO - consider only using FHIR entities in service layer
         identifier_system = immunization["identifier"][0]["system"]
         identifier_value = immunization["identifier"][0]["value"]
 

infrastructure/instance/file_name_processor.tf

@@ -312,6 +312,10 @@ resource "aws_s3_bucket_notification" "datasources_lambda_notification" {
     lambda_function_arn = aws_lambda_function.file_processor_lambda.arn
     events              = ["s3:ObjectCreated:*"]
   }
+
+  depends_on = [
+    aws_lambda_permission.s3_invoke_permission
+  ]
 }
 
 resource "aws_cloudwatch_log_group" "file_name_processor_log_group" {

infrastructure/instance/mesh_processor.tf

@@ -244,6 +244,10 @@ resource "aws_s3_bucket_notification" "mesh_datasources_lambda_notification" {
     events              = ["s3:ObjectCreated:*"]
     filter_prefix       = "inbound/"
   }
+
+  depends_on = [
+    aws_lambda_permission.mesh_s3_invoke_permission
+  ]
 }
 
 resource "aws_cloudwatch_log_group" "mesh_file_converter_log_group" {

infrastructure/instance/redis_sync_lambda.tf

@@ -264,7 +264,7 @@ resource "aws_s3_bucket_notification" "config_lambda_notification" {
   }
 
   depends_on = [
-    aws_lambda_function.redis_sync_lambda
+    aws_lambda_permission.new_s3_invoke_permission
   ]
 }