Initial refactoring of pipelines

Author: dlzhry2nhs

.github/workflows/pr-lint.yaml .github/workflows/pr-jira-link.yaml.github/workflows/pr-lint.yaml renamed to .github/workflows/pr-jira-link.yaml

@@ -1,4 +1,4 @@
-name: PR Quality Check
+name: Create PR JIRA Link
 on:
   pull_request:
     types: [opened]

.github/workflows/sonarcloud.yml .github/workflows/quality-checks.yml.github/workflows/sonarcloud.yml renamed to .github/workflows/quality-checks.yml

@@ -1,4 +1,4 @@
-name: SonarCloud
+name: Quality Checks
 
 on:
   push:
@@ -12,14 +12,38 @@ env:
   LAMBDA_PATH: ${{ github.workspace }}/lambdas
 
 jobs:
-  sonarcloud:
-    name: SonarCloud
+  lint:
+    name: Lint specification and Python projects
     runs-on: ubuntu-latest
-
+    
     steps:
       - uses: actions/checkout@v5
+
+      - name: Install poetry
+        run: pip install poetry==2.1.4
+
+      - uses: actions/setup-python@v5
         with:
-          fetch-depth: 0
+          python-version: 3.8
+          cache: 'poetry'
+
+      - uses: actions/setup-node@v5
+        with:
+          node-version: '23.11.0'
+          cache: 'npm'
+
+      - name: Install linting dependencies
+        run: make install-node && poetry install --no-root
+      
+      - name: Lint
+        run: make lint
+
+  testcoverage_and_sonarcloud:
+    name: Test Coverage and SonarCloud
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
 
       - name: Install poetry
         run: pip install poetry==2.1.4

README.md

@@ -175,7 +175,7 @@ It is not necessary to activate the virtual environment (using `source .venv/bin
 The root-level virtual environment is primarily used for linting, as we create separate virtual environments for each folder that contains Lambda functions.
 Steps: 
 1. Follow instructions above to [install dependencies](#install-dependencies) & [set up a virtual environment](#setting-up-a-virtual-environment-with-poetry). 
-**Note: While this project uses Python 3.10 (e.g. for Lambdas), the NHSDigital/api-management-utils repository — which orchestrates setup and linting — defaults to Python 3.8.
+**Note: While this project uses Python 3.11 (e.g. for Lambdas), the NHSDigital/api-management-utils repository — which orchestrates setup and linting — defaults to Python 3.8.
 The linting command is executed from within that repo but calls the Makefile in this project, so be aware of potential Python version mismatches when running or debugging locally or in the pipeline.**
 2. Run `make lint`. This will:
     - Check the linting of the API specification yaml.

README.specification.md

@@ -102,7 +102,7 @@ To get started developing your API use this template repo alongside guidance pro
 This folder contains templates that can be customised for items such as opening pull requests or issues within the repo
 
 `/.github/workflows`: This folder contains templates for github action workflows such as:
-- `pr-lint.yaml`: This workflow template shows how to link Pull Request's to Jira tickets and runs when a pull request is opened.
+- `pr-jira-link.yaml`: This workflow template links Pull Requests to Jira tickets and runs when a pull request is opened.
 - `continuous-integration.yml`: This workflow template shows how to publish a Github release when pushing to master.
 
 #### `/azure`:

pyproject.toml

@@ -1,4 +1,5 @@
 [project]
+name = "immunisation-fhir-api"
 python = "^3.8"
 
 [tool.poetry]