Migrate comment missed in the original refactoring work

dlzhry2nhs · dlzhry2nhs · commit ed94f43a78f9 · 2025-11-03T08:33:41.000Z
diff --git a/lambdas/shared/src/common/log_firehose.py b/lambdas/shared/src/common/log_firehose.py
@@ -6,6 +6,9 @@
 )
 
 
+# Not keen on including blocking calls in function code to forward log data to Splunk (via Firehose)
+# Consider simply logging and setting up CW subscription filters to forward to Firehose
+# https://docs.aws.amazon.com/firehose/latest/dev/writing-with-cloudwatch-logs.html
 def send_log_to_firehose(stream_name: str, log_data: dict) -> None:
     """Sends the log_message to Firehose"""
     try:

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,9 @@`
`6`	`6`	`)`
`7`	`7`
`8`	`8`
	`9`	`+# Not keen on including blocking calls in function code to forward log data to Splunk (via Firehose)`
	`10`	`+# Consider simply logging and setting up CW subscription filters to forward to Firehose`
	`11`	`+# https://docs.aws.amazon.com/firehose/latest/dev/writing-with-cloudwatch-logs.html`
`9`	`12`	`def send_log_to_firehose(stream_name: str, log_data: dict) -> None:`
`10`	`13`	`"""Sends the log_message to Firehose"""`
`11`	`14`	`try:`