final review

Author: Akol125

backend/src/fhir_controller.py

@@ -431,6 +431,7 @@ def search_immunizations(self, aws_event: APIGatewayProxyEventV1) -> dict:
                 for vaccine_type in search_params.immunization_targets
                 if ApiOperationCode.SEARCH in expanded_permissions.get(vaccine_type.lower(), [])
             ]
+            print(f"vax type perm: {vax_type_perm}, expanded_permissions {expanded_permissions} ")
             if not vax_type_perm:
                 raise UnauthorizedVaxError
         except UnauthorizedVaxError as unauthorized:

backend/src/fhir_repository.py

@@ -358,7 +358,7 @@ def delete_immunization(
             if not item:
                 raise ResourceNotFoundError(resource_type="Immunization", resource_id=imms_id)
 
-            if item.get("DeletedAt") == "reinstated":
+            if not item.get("DeletedAt") or item.get("DeletedAt") == "reinstated":
                 vaccine_type = self._vaccine_type(item["PatientSK"])
                 if not validate_permissions(imms_vax_type_perms, ApiOperationCode.DELETE, [vaccine_type]):
                     raise UnauthorizedVaxError()

backend/tests/sample_data/permissions_config.py

@@ -11,7 +11,6 @@
 You can ignore these tests if you are running them in your local environment"""
 
 
-@unittest.skip("This test is skipped because it requires a live FHIR server connection.")
 class TestDeployment(unittest.TestCase):
     proxy_url: str
     status_api_key: str

e2e/test_deployment.py

@@ -7,7 +7,6 @@
 from lib.env import get_service_base_path, get_status_endpoint_api_key
 
 
-@unittest.skip("Skipping test for now")
 class TestProxyHealthcheck(unittest.TestCase):
 
     proxy_url: str

e2e/test_proxy.py

@@ -7,7 +7,6 @@
 from botocore.exceptions import ClientError  # Handle potential errors
 
 
-@unittest.skip("This test is skipped because it requires a live SQS connection.")
 class TestSQS(unittest.TestCase):
 
     def setUp(self):