align mns

Author: nhsdevws

azure/templates/post-deploy.yml

@@ -81,6 +81,26 @@ steps:
     workingDirectory: "$(Pipeline.Workspace)/s/$(SERVICE_NAME)/$(SERVICE_ARTIFACT_NAME)"
     retryCountOnTaskFailure: 2
 
+  - ${{ if eq(parameters.subscribe_to_mns, true) }}:
+    - bash: |
+        export AWS_PROFILE=apim-dev
+        echo "Subscribing SQS to MNS for notifications."
+        pyenv install -s 3.11.11
+        pyenv local 3.11.11
+        echo "Setting up poetry environment..."
+        poetry env use 3.11
+        poetry install --no-root
+
+        echo "Setting PYTHONPATH..."
+        export PYTHONPATH=$(Pipeline.Workspace)/s/$(SERVICE_NAME)/$(SERVICE_ARTIFACT_NAME)/mns_subscription
+
+        echo "Subscribing SQS to MNS for notifications..."
+        poetry run python src/subscribe_mns.py
+      displayName: "Run MNS Subscription"
+      workingDirectory: "$(Pipeline.Workspace)/s/$(SERVICE_NAME)/$(SERVICE_ARTIFACT_NAME)/mns_subscription"
+      env:
+        SQS_ARN: "$(ID_SYNC_QUEUE_ARN)"
+
   - bash: |
       set -ex
 

lambdas/id_sync/src/ieds_db_operations.py

@@ -117,25 +117,6 @@ def ieds_update_patient_id(old_id: str, new_id: str) -> dict:
             exception=e
         )
 
-# def test_ieds_insert_patient(patient_id: str) -> dict:  # NOSONAR
-#     """Test function for inserting patient ID."""
-#     logger.info("insert to db...")
-#     # write the patient id to table
-#     res = '{"resourceType": "Immunization"}'
-#     result = get_ieds_table().put_item(Item={
-#                     "PK": f"Patient#{patient_id}",
-#                     "PatientPK": f"Patient#{patient_id}",
-#                     "PatientSK": f"Patient#{patient_id}",
-#                     "Resource": res,
-#                     "IdentifierPK": "https://www.ieds.england.nhs.uk/#a7e06f66-339f-4b81-b2f6-016b88bfc422",
-#                     "Operation": "CREATE",
-#                     "Version": "1",
-#                     "SupplierSystem": "RAVS",
-#                 })
-
-#     logger.info(f"Test result: {result}")
-#     return result
-
 
 def get_items_from_patient_id(id: str, limit=BATCH_SIZE) -> list:
     """Get all items for patient ID."""

sonar-project.properties

@@ -4,13 +4,13 @@ sonar.organization=nhsdigital
 sonar.host.url=https://sonarcloud.io
 sonar.python.version=3.11
 sonar.exclusions=**/e2e/**,**/e2e_batch/**,**/temporary_sandbox/**,**/devtools/**,**/proxies/**,**/scripts/**,**/terraform/**,**/tests/**,redis_sync/src/log_decorator.py
-sonar.coverage.exclusions=lambdas/id_sync/src/**,lambdas/shared/src/**
 sonar.cpd.exclusions=**/cache.py,**/authentication.py,**/test_cache.py,**/test_authentication.py,**/mns_service.py,**/errors.py,specification/**,redis_sync/src/log_decorator.py,**/Dockerfile,lambdas/shared/src/common/**
 sonar.python.coverage.reportPaths=backend-coverage.xml,delta-coverage.xml,ack-lambda-coverage.xml,filenameprocessor-coverage.xml,recordforwarder-coverage.xml,recordprocessor-coverage.xml,mesh_processor-coverage.xml,redis_sync-coverage.xml,mns_subscription-coverage.xml
 sonar.issue.ignore.multicriteria=exclude_snomed_urls,exclude_hl7_urls,exclude_mns_setup
 sonar.issue.ignore.multicriteria.exclude_snomed_urls.ruleKey=python:S5332
 sonar.issue.ignore.multicriteria.exclude_snomed_urls.resourceKey=**http://snomed\.info/sct**
 sonar.issue.ignore.multicriteria.exclude_hl7_urls.ruleKey=python:S5332
 sonar.issue.ignore.multicriteria.exclude_hl7_urls.resourceKey=**http://terminology\.hl7\.org/CodeSystem/v3-NullFlavor**
-sonar.issue.ignore.multicriteria.exclude_mns_setup.ruleKey=python:S5443
-sonar.issue.ignore.multicriteria.exclude_mns_setup.resourceKey=**/mns_setup.py
+sonar.issue.ignore.multicriteria=e1
+sonar.issue.ignore.multicriteria.e1.ruleKey=python:S5443
+sonar.issue.ignore.multicriteria.e1.resourceKey=**/mns_setup.py