VED-386: Fix lint error. Tidy up a couple of tests.

Author: mfjarvis

filenameprocessor/src/send_sqs_message.py

@@ -27,7 +27,12 @@ def send_to_supplier_queue(message_body: dict, vaccine_type: str, supplier: str)
 
 
 def make_and_send_sqs_message(
-    file_key: str, message_id: str, permission: list[str], vaccine_type: str, supplier: str, created_at_formatted_string: str
+    file_key: str,
+    message_id: str,
+    permission: list[str],
+    vaccine_type: str,
+    supplier: str,
+    created_at_formatted_string: str
 ) -> None:
     """Attempts to send a message to the SQS queue. Raises an exception if the message is not successfully sent."""
     message_body = {

filenameprocessor/tests/test_elasticache.py

@@ -29,16 +29,14 @@ def tearDown(self):
         """Tear down the S3 buckets"""
         GenericTearDown(s3_client)
 
-    @patch("elasticache.redis_client")
-    def test_get_supplier_permissions_from_cache(self, mock_redis_client):
-        mock_redis_client.hget.return_value = json.dumps(["COVID19.CRUDS", "RSV.CRUDS"])
+    @patch("elasticache.redis_client.hget", return_value=json.dumps(["COVID19.CRUDS", "RSV.CRUDS"]))
+    def test_get_supplier_permissions_from_cache(self, mock_hget):
         result = get_supplier_permissions_from_cache("TEST_SUPPLIER")
         self.assertEqual(result, ["COVID19.CRUDS", "RSV.CRUDS"])
-        mock_redis_client.hget.assert_called_once_with("supplier_permissions", "TEST_SUPPLIER")
+        mock_hget.assert_called_once_with("supplier_permissions", "TEST_SUPPLIER")
 
-    @patch("elasticache.redis_client")
-    def test_get_supplier_permissions_from_cache_not_found(self, mock_redis_client):
-        mock_redis_client.hget.return_value = None
+    @patch("elasticache.redis_client.hget", return_value=None)
+    def test_get_supplier_permissions_from_cache_not_found(self, mock_hget):
         result = get_supplier_permissions_from_cache("TEST_SUPPLIER")
         self.assertEqual(result, [])
-        mock_redis_client.hget.assert_called_once_with("supplier_permissions", "TEST_SUPPLIER")
+        mock_hget.assert_called_once_with("supplier_permissions", "TEST_SUPPLIER")