finalize edge cases

Author: Akol125

delta_backend/src/ConversionChecker.py

@@ -234,17 +234,15 @@ def _convertToDose(self, expressionRule, fieldName, fieldValue, summarise, repor
             return fieldValue
         return "" 
 
-    # Change to Lookup
+    # Change to Lookup (loads expected data as is but if empty use lookup extraction to populate value)
     def _convertToLookUp(self, expressionRule, fieldName, fieldValue, summarise, report_unexpected_exception):
+        if isinstance(fieldValue, str) and any(char.isalpha() for char in fieldValue) and not fieldValue.isdigit():
+            return fieldValue
         try:
-            if fieldValue != "":
-                return fieldValue
-            try:
                 lookUpValue = self.dataParser.getKeyValue(expressionRule)
                 IdentifiedLookup = self.dataLookUp.findLookUp(lookUpValue[0])
                 return IdentifiedLookup
-            except:
-                return ""
+        
         except Exception as e:
             if report_unexpected_exception:
                 message = ExceptionMessages.MESSAGES[ExceptionMessages.UNEXPECTED_EXCEPTION] % (e.__class__.__name__, e)

delta_backend/src/log_firehose.py

@@ -19,10 +19,6 @@ def __init__(
         self.delivery_stream_name = stream_name
 
     def send_log(self, log_message):
-        # if not self.delivery_stream_name:
-        #     logger.warning("No SPLUNK_FIREHOSE_NAME set — skipping Firehose log.")
-        #     return
-        
         log_to_splunk = log_message
         logger.info(f"Log sent to Firehose for save: {log_to_splunk}")
         encoded_log_data = json.dumps(log_to_splunk).encode("utf-8")