Skip to content

Conversation

@Akol125
Copy link
Contributor

@Akol125 Akol125 commented May 19, 2025

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

identifier:
- system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9449306206'
birthDate: '2014-03-25'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does birthDate also need removing from specification/components/schemas/GetResponse.yaml?

Copy link
Contributor Author

@Akol125 Akol125 Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh looks like I misunderstood the question. I would look into it and confirm again if it needs to be removed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

@dlzhry2nhs
Copy link
Contributor

PR still needed? If not please close.

@dlzhry2nhs
Copy link
Contributor

I am closing the PR. The branch is still there if you need to work from it again in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants