Skip to content

Comments

VED-807 Refactor backend#967

Merged
JamesW1-NHS merged 74 commits intomasterfrom
VED-807-refactor-backend
Nov 13, 2025
Merged

VED-807 Refactor backend#967
JamesW1-NHS merged 74 commits intomasterfrom
VED-807-refactor-backend

Conversation

@JamesW1-NHS
Copy link
Contributor

@JamesW1-NHS JamesW1-NHS commented Nov 4, 2025

Summary

Note to Testers: There is no change in functionality here. Refactoring only.

  • Routine Change

This is the refactoring of the backend lambda into the lambdas/ and shared/ folders.

Some components have been tidied up and refactored from other lambdas in the course of this. Examples:

  • errors.py files: only errors which are common to two or more lambdas are in shared/; all others are in errors.py files local to their lambdas.
  • All instances of an s3 client are now singletons from common.clients.get_s3_client
  • Ditto redis client: common.redis_client.get_redis_client
  • Some duplicated utility functions have been refactored into shared e.g. move_file()

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-807

@sonarqubecloud
Copy link

@JamesW1-NHS JamesW1-NHS merged commit 954c7e3 into master Nov 13, 2025
17 checks passed
@JamesW1-NHS JamesW1-NHS deleted the VED-807-refactor-backend branch November 13, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants