Skip to content

Commit b38b2f7

Browse files
NAID-3325: Values incorrect when mapping to codeable concepts for condition
* Update unit test to reflect the correct population of `code.coding[].system` and `code.coding[].code` * Update integration test expected result JSON for `primary emergency` to ensure to test the correct population of the above. * Update test harness expected result JSON for `primary emergency` to ensure to test the correct population of the above. * Update `CodeUtil` to ensure that the values for `code.coding[].system` and `code.coding[].code` are now populated correctly.
1 parent 915a9ed commit b38b2f7

File tree

4 files changed

+14
-9
lines changed

4 files changed

+14
-9
lines changed

doc/json/primary-emergency-fhir-result.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -828,8 +828,8 @@
828828
"verificationStatus": "unknown",
829829
"code": {
830830
"coding": [ {
831-
"system": "22298006",
832-
"code": "2.16.840.1.113883.2.1.3.2.4.15",
831+
"system": "2.16.840.1.113883.2.1.3.2.4.15",
832+
"code": "22298006",
833833
"display": "Myocardial infarction"
834834
} ]
835835
},

service/src/integration-test/resources/json/primary-emergency-fhir-result.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -828,8 +828,8 @@
828828
"verificationStatus": "unknown",
829829
"code": {
830830
"coding": [ {
831-
"system": "22298006",
832-
"code": "2.16.840.1.113883.2.1.3.2.4.15",
831+
"system": "2.16.840.1.113883.2.1.3.2.4.15",
832+
"code": "22298006",
833833
"display": "Myocardial infarction"
834834
} ]
835835
},

service/src/main/java/uk/nhs/adaptors/oneoneone/cda/report/util/CodeUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ public class CodeUtil {
1212
public static CodeableConcept createCodeableConceptList(CE ce) {
1313
CodeableConcept codeableConcept = new CodeableConcept();
1414
Coding coding = new Coding();
15-
coding.setCode(ce.getCodeSystem());
15+
coding.setCode(ce.getCode());
1616
coding.setDisplay(ce.getDisplayName());
17-
coding.setSystem(ce.getCode());
17+
coding.setSystem(ce.getCodeSystem());
1818
codeableConcept.addCoding(coding);
1919

2020
return codeableConcept;

service/src/test/java/uk/nhs/adaptors/oneoneone/cda/report/util/CodeUtilTest.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,14 @@ public void shouldCreateCodeableConcept() {
2424
when(ce.getCodeSystem()).thenReturn(codeSystem);
2525
when(ce.getCode()).thenReturn(code);
2626
when(ce.getDisplayName()).thenReturn(displayName);
27+
2728
CodeableConcept codeableConcept = CodeUtil.createCodeableConceptList(ce);
28-
assertThat(codeableConcept.getCoding().get(0).getCode()).isEqualTo(codeSystem);
29-
assertThat(codeableConcept.getCoding().get(0).getDisplay()).isEqualTo(displayName);
30-
assertThat(codeableConcept.getCoding().get(0).getSystem()).isEqualTo(code);
29+
30+
assertThat(codeableConcept.getCoding().getFirst().getCode())
31+
.isEqualTo(code);
32+
assertThat(codeableConcept.getCoding().getFirst().getDisplay())
33+
.isEqualTo(displayName);
34+
assertThat(codeableConcept.getCoding().getFirst().getSystem())
35+
.isEqualTo(codeSystem);
3136
}
3237
}

0 commit comments

Comments
 (0)