Skip to content

Commit 09bdec6

Browse files
committed
Rename test to be clearer
1 parent 3fa64f7 commit 09bdec6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

service/src/test/java/uk/nhs/adaptors/gp2gp/common/service/FhirParseServiceTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ void setUp() {
3030
ObjectMapperBean objectMapperBean = new ObjectMapperBean();
3131
objectMapper = objectMapperBean.objectMapper(new Jackson2ObjectMapperBuilder());
3232

33-
var details = getCodeableConcept(INVALID_IDENTIFIER_VALUE);
33+
var details = getCodeableConcept();
3434
var diagnostics = "Provide a conversationId that exists and retry the operation";
3535
operationOutcome = EhrResendController.createOperationOutcome(OperationOutcome.IssueType.VALUE,
3636
OperationOutcome.IssueSeverity.ERROR,
@@ -39,7 +39,7 @@ void setUp() {
3939
}
4040

4141
@Test
42-
void parseOperationOutcomeTest() throws JsonProcessingException {
42+
void ableToEncodeOperationOutcomeToJson() throws JsonProcessingException {
4343
FhirParseService fhirParseService = new FhirParseService();
4444

4545
String convertedToJsonOperationOutcome = fhirParseService.encodeToJson(operationOutcome);
@@ -53,11 +53,11 @@ void parseOperationOutcomeTest() throws JsonProcessingException {
5353
assertEquals(OPERATION_OUTCOME_URL, operationOutcomeUrl);
5454
}
5555

56-
private static CodeableConcept getCodeableConcept(String codeableConceptCode) {
56+
private static CodeableConcept getCodeableConcept() {
5757
var details = new CodeableConcept();
5858
var codeableConceptCoding = new Coding();
5959
codeableConceptCoding.setSystem("http://fhir.nhs.net/ValueSet/gpconnect-error-or-warning-code-1");
60-
codeableConceptCoding.setCode(codeableConceptCode);
60+
codeableConceptCoding.setCode(FhirParseServiceTest.INVALID_IDENTIFIER_VALUE);
6161
details.setCoding(List.of(codeableConceptCoding));
6262
return details;
6363
}

0 commit comments

Comments
 (0)