suppress false positive alarms sent by spotbugs

Author: ORybak5

service/src/main/java/uk/nhs/adaptors/gp2gp/common/configuration/CustomTrustStore.java

@@ -25,9 +25,10 @@
 
 @Component
 @Slf4j
+@SuppressFBWarnings(value = "EI_EXPOSE_REP2", justification = "S3Client is immutable and thread-safe.")
 public class CustomTrustStore {
 
-    private S3Client s3Client;
+    private final S3Client s3Client;
 
     @Autowired
     public CustomTrustStore(S3Client s3Client) {

service/src/test/java/uk/nhs/adaptors/gp2gp/common/configuration/CustomTrustStoreTest.java

@@ -13,7 +13,6 @@
 import software.amazon.awssdk.services.s3.model.CreateBucketRequest;
 import software.amazon.awssdk.services.s3.model.PutObjectRequest;
 import java.io.File;
-import java.lang.reflect.Field;
 import java.net.URI;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
@@ -61,10 +60,6 @@ static void tearDown() {
     @Test
     void trustManagerLoadsSuccessfullyTest() throws NoSuchFieldException, IllegalAccessException {
 
-        Field s3ClientField = CustomTrustStore.class.getDeclaredField("s3Client");
-        s3ClientField.setAccessible(true);
-        s3ClientField.set(customTrustStore, s3Client);
-
         String s3Uri = "s3://" + BUCKET_NAME + "/" + TRUSTSTORE_PATH;
 
         var trustManager = customTrustStore.getCustomDbTrustManager(s3Client.utilities().parseUri(URI.create(s3Uri)), TRUSTSTORE_PASSWORD);