adding test coverage

Author: ORybak5

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapper.java

@@ -168,7 +168,7 @@ private boolean hasObservationsWithoutSpecimen(List<Observation> observations) {
     /**
      * For correct display in EMIS, any observation without a specimen must be assigned a dummy specimen.
      */
-    private List<Observation> assignDummySpecimensToObservationsWithNoSpecimen(
+    protected List<Observation> assignDummySpecimensToObservationsWithNoSpecimen(
         List<Observation> observations, List<Specimen> specimens) {
 
         List<Observation> filingComments = getFilingComments(observations);

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapperTest.java

@@ -1,6 +1,7 @@
 package uk.nhs.adaptors.gp2gp.ehr.mapper.diagnosticreport;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.assertAll;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.when;
@@ -61,6 +62,7 @@ class DiagnosticReportMapperTest {
     private static final String INPUT_JSON_BUNDLE_WITH_FILING_COMMENTS = "fhir_bundle_with_filing_comments.json";
 
     private static final String TEST_ID = "5E496953-065B-41F2-9577-BE8F2FBD0757";
+    public static final String NOT_PRESENT_SPECIMEN_ID_PREFIX = "NOT-PRESENT-SPECIMEN-";
 
     private static final String INPUT_JSON_REQUIRED_DATA = "diagnostic-report-with-required-data.json";
     private static final String INPUT_JSON_EMPTY_SPECIMENS = "diagnostic-report-with-empty-specimens.json";
@@ -129,6 +131,44 @@ public void tearDown() {
         messageContext.resetMessageContext();
     }
 
+    @Test
+    void shouldAssignDummySpecimenToObservationsWithoutSpecimen() {
+
+        Observation obsWithoutSpecimen = new Observation();
+        Observation obsWithSpecimen = new Observation();
+        obsWithSpecimen.setSpecimen(new Reference("real-specimen"));
+
+        List<Observation> observations = List.of(obsWithoutSpecimen, obsWithSpecimen);
+
+        Specimen dummySpecimen = new Specimen();
+        dummySpecimen.setId("dummy-" + NOT_PRESENT_SPECIMEN_ID_PREFIX);
+        Specimen realSpecimen = new Specimen();
+        realSpecimen.setId("real-specimen");
+        List<Specimen> specimens = List.of(realSpecimen, dummySpecimen);
+
+        List<Observation> result = mapper.assignDummySpecimensToObservationsWithNoSpecimen(observations, specimens);
+
+        assertThat(result).hasSize(2);
+        assertThat(result.get(0).getSpecimen().getReference()).contains(dummySpecimen.getId());
+        assertThat(result.get(1).getSpecimen().getReference()).contains("real-specimen");
+    }
+
+    @Test
+    void shouldThrowIfNoDummySpecimenFound() {
+
+        Observation obsWithoutSpecimen = new Observation();
+        List<Observation> observations = List.of(obsWithoutSpecimen);
+
+        Specimen realSpecimen = new Specimen();
+        realSpecimen.setId("real-specimen");
+        List<Specimen> specimens = List.of(realSpecimen);
+
+        assertThatThrownBy(() ->
+                               mapper.assignDummySpecimensToObservationsWithNoSpecimen(observations, specimens))
+            .isInstanceOf(IllegalStateException.class)
+            .hasMessageContaining(NOT_PRESENT_SPECIMEN_ID_PREFIX);
+    }
+
     @ParameterizedTest
     @MethodSource("resourceFileParams")
     void When_MappingDiagnosticReportJson_Expect_CompoundStatementXmlOutput(String inputJson, String outputXml) {