Skip to content

Commit 1e4945e

Browse files
author
Adrian Clay
authored
Refactor: Replace useless numbers in test filenamess with descriptions (#1105)
* Refactor: Replace useless numbers in test filenamess with descriptions The expected XML/JSON filenames had an integer value which is printed by JUnit as part of the MethodSource ParameterizedTest execution. As a result these filenames are useless as the description of what each filename meant was within the Java constants. Inline each constant, and rename the expected filenames to be more descriptive. * Refactor: Remove public modifier from tests
1 parent 4569345 commit 1e4945e

File tree

52 files changed

+40
-122
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+40
-122
lines changed

‎service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/AllergyStructureMapperTest.java‎

Lines changed: 40 additions & 122 deletions
Large diffs are not rendered by default.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-4.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-dates.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-14.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-device-recorder-and-asserter.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-17.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-end-date.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-7.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-environment-category.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-2.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-medication-category.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-18.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-no-author-or-performer.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-5.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-no-optional-text-fields.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-12.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-no-relation-to-condition.xml

File renamed without changes.

service/src/test/resources/ehr/mapper/allergy/expected-output-allergy-structure-6.xml renamed to service/src/test/resources/ehr/mapper/allergy/expected-uses-null-flavor-date.xml

File renamed without changes.

0 commit comments

Comments
 (0)