Skip to content

Commit 253066f

Browse files
authored
Post-merge code tidy up for NIAD-3213 (#959)
* [NIAD-3213-CLEAN-UP] Remove unnecessary comment * [NIAD-3213-CLEAN-UP] Tighten down ArgumentMatchers
1 parent 5ef5038 commit 253066f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/SpecimenMapper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ private String mapObservationsAssociatedWithSpecimen(Specimen specimen, List<Obs
142142
if (dummySpecimenOrObservationExists(specimen, observations)) {
143143
observationsAssociatedWithSpecimen = observations;
144144
} else {
145-
// Implicitly filtering out filing comments.
146145
observationsAssociatedWithSpecimen = observations.stream()
147146
.filter(Observation::hasSpecimen)
148147
.filter(observation -> observation.getSpecimen().getReference().equals(specimen.getId()))

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapperTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,11 @@ void When_DiagnosticReport_With_NoReferencedSpecimenAndFilingCommentWithNoCommen
258258
final InputBundle inputBundle = new InputBundle(bundle);
259259
final String expectedXml = getXmlStringFromFile(TEST_FILE_DIRECTORY, "diagnostic-report-with-no-specimen.xml");
260260

261-
when(specimenMapper.mapSpecimenToCompoundStatement(any(), anyList(), any()))
262-
.thenCallRealMethod();
261+
when(specimenMapper.mapSpecimenToCompoundStatement(
262+
any(Specimen.class),
263+
anyList(),
264+
any(DiagnosticReport.class)
265+
)).thenCallRealMethod();
263266

264267
when(messageContext.getInputBundleHolder()).thenReturn(inputBundle);
265268

0 commit comments

Comments
 (0)