remove

Author: chiaramapellimt

service/src/test/java/uk/nhs/adaptors/gp2gp/common/task/TaskErrorHandlerTest.java

@@ -14,14 +14,11 @@
 
 import java.util.concurrent.TimeoutException;
 
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-import org.mockito.junit.jupiter.MockitoSettings;
-import org.mockito.quality.Strictness;
 
 import lombok.SneakyThrows;
 import uk.nhs.adaptors.gp2gp.common.exception.FhirValidationException;
@@ -50,13 +47,9 @@ class TaskErrorHandlerTest {
     @InjectMocks
     private TaskErrorHandler taskErrorHandler;
 
-    @BeforeEach
-    void setup() {
-        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
-    }
-
     @Test
     void When_HandleProcessingError_WithEhrRequestException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new EhrRequestException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -68,6 +61,7 @@ void When_HandleProcessingError_WithEhrRequestException_Expect_ProcessToBeFailed
 
     @Test
     void When_HandleProcessingError_WithEhrValidationException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new EhrValidationException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -79,6 +73,7 @@ void When_HandleProcessingError_WithEhrValidationException_Expect_ProcessToBeFai
 
     @Test
     void When_HandleProcessingError_WithEhrRequestException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -88,6 +83,7 @@ void When_HandleProcessingError_WithEhrRequestException_Expect_ReturnValueOfFail
 
     @Test
     void When_HandleProcessingError_With_EhrExtractException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new EhrExtractException("Test Exception"), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -99,6 +95,7 @@ void When_HandleProcessingError_With_EhrExtractException_Expect_ProcessToBeFaile
 
     @Test
     void When_HandleProcessingError_WithEhrExtractException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -108,6 +105,7 @@ void When_HandleProcessingError_WithEhrExtractException_Expect_ReturnValueOfFail
 
     @Test
     void When_HandleProcessingError_WithEhrMapperException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new EhrMapperException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -119,6 +117,7 @@ void When_HandleProcessingError_WithEhrMapperException_Expect_ProcessToBeFailedW
 
     @Test
     void When_HandleProcessingError_WithEhrMapperException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -128,6 +127,7 @@ void When_HandleProcessingError_WithEhrMapperException_Expect_ReturnValueOfFailS
 
     @Test
     void When_HandleProcessingError_WithFhirValidationException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new FhirValidationException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -139,6 +139,7 @@ void When_HandleProcessingError_WithFhirValidationException_Expect_ProcessToBeFa
 
     @Test
     void When_HandleProcessingError_WithFhirValidationException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -148,6 +149,7 @@ void When_HandleProcessingError_WithFhirValidationException_Expect_ReturnValueOf
 
     @Test
     void When_HandleProcessingError_WithOtherException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new Exception(), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -159,6 +161,7 @@ void When_HandleProcessingError_WithOtherException_Expect_ProcessToBeFailedWithC
 
     @Test
     void When_HandleProcessingError_WithOtherException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -168,6 +171,7 @@ void When_HandleProcessingError_WithOtherException_Expect_ReturnValueOfFailServi
 
     @Test
     void When_HandleProcessingError_WithGpConnectException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new GpConnectException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -179,6 +183,7 @@ void When_HandleProcessingError_WithGpConnectException_Expect_ProcessToBeFailedW
 
     @Test
     void When_HandleProcessingError_WithGpConnectException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -188,6 +193,7 @@ void When_HandleProcessingError_WithGpConnectException_Expect_ReturnValueOfFailS
 
     @Test
     void When_HandleProcessingError_WithGpConnectInvalidException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new GpConnectInvalidException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -199,6 +205,7 @@ void When_HandleProcessingError_WithGpConnectInvalidException_Expect_ProcessToBe
 
     @Test
     void When_HandleProcessingError_WithGpConnectInvalidException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -208,6 +215,7 @@ void When_HandleProcessingError_WithGpConnectInvalidException_Expect_ReturnValue
 
     @Test
     void When_HandleProcessingError_WithGpConnectGpConnectNotFoundException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new GpConnectNotFoundException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -219,6 +227,7 @@ void When_HandleProcessingError_WithGpConnectGpConnectNotFoundException_Expect_P
 
     @Test
     void When_HandleProcessingError_WithGpConnectNotFoundException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -228,6 +237,7 @@ void When_HandleProcessingError_WithGpConnectNotFoundException_Expect_ReturnValu
 
     @Test
     void When_HandleProcessingError_WithMaximumExternalAttachmentsException_Expect_ProcessToBeFailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         taskErrorHandler.handleProcessingError(new MaximumExternalAttachmentsException(TEST_EXCEPTION_MESSAGE), taskDefinition);
 
         verify(processFailureHandlingService).failProcess(
@@ -239,6 +249,7 @@ void When_HandleProcessingError_WithMaximumExternalAttachmentsException_Expect_P
 
     @Test
     void When_HandleProcessingError_WithMaximumExternalAttachmentsException_Expect_ReturnValueOfFailService() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         when(processFailureHandlingService.failProcess(any(), any(), any(), any()))
             .thenReturn(true, false);
 
@@ -251,7 +262,6 @@ void When_HandleProcessingError_WithMaximumExternalAttachmentsException_Expect_R
     }
 
     @Test
-    @MockitoSettings(strictness = Strictness.LENIENT)
     void When_HandleGeneralProcessingError_WithNullParameter_Expect_ProcessIsNotFailed() {
         taskErrorHandler.handleProcessingError(new RuntimeException(), null);
 
@@ -260,6 +270,7 @@ void When_HandleGeneralProcessingError_WithNullParameter_Expect_ProcessIsNotFail
     @Test
     @SneakyThrows
     void When_FailProcessThrowsException_Expect_ExceptionToBeRethrown() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         var failureHandlingException = new RuntimeException("failure handler exception");
         doThrow(failureHandlingException).when(processFailureHandlingService).failProcess(
             any(), any(), any(), any());
@@ -272,6 +283,7 @@ void When_FailProcessThrowsException_Expect_ExceptionToBeRethrown() {
     @Test
     @SneakyThrows
     void When_HandleProcessingError_WithGpcServerErrorExceptionAsRootCause_Expect_FailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         Throwable testException = new RetryLimitReachedException("test", new GpcServerErrorException("exception"));
 
         taskErrorHandler.handleProcessingError(testException, taskDefinition);
@@ -286,6 +298,7 @@ void When_HandleProcessingError_WithGpcServerErrorExceptionAsRootCause_Expect_Fa
     @Test
     @SneakyThrows
     void When_HandleProcessingError_WithTimeoutExceptionAsRootCause_Expect_FailedWithCorrectCode() {
+        when(taskDefinition.getTaskType()).thenReturn(GET_GPC_STRUCTURED);
         Throwable testException = new RetryLimitReachedException("test", new TimeoutException("exception"));
 
         taskErrorHandler.handleProcessingError(testException, taskDefinition);