Skip to content

Commit 5a72e5e

Browse files
committed
addressing pitest mutations
1 parent cfd35bb commit 5a72e5e

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

service/src/main/java/uk/nhs/adaptors/gp2gp/common/storage/StorageConnectorFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import org.springframework.beans.factory.FactoryBean;
44

55
import lombok.Setter;
6+
import software.amazon.awssdk.regions.Region;
67
import software.amazon.awssdk.services.s3.S3Client;
78

89
@Setter
@@ -16,7 +17,7 @@ public StorageConnector getObject() {
1617
if (storageConnector == null) {
1718
switch (StorageConnectorOptions.enumOf(configuration.getType())) {
1819
case S3:
19-
storageConnector = new S3StorageConnector(S3Client.builder().build(), configuration);
20+
storageConnector = new S3StorageConnector(S3Client.builder().region(Region.EU_WEST_2).build(), configuration);
2021
break;
2122
case AZURE:
2223
storageConnector = new AzureStorageConnector();
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
package uk.nhs.adaptors.gp2gp.common.storage;
2+
3+
import org.junit.jupiter.api.BeforeEach;
4+
import org.junit.jupiter.api.Test;
5+
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
6+
7+
class StorageConnectorFactoryTest {
8+
9+
private StorageConnectorFactory storageConnectorFactory;
10+
11+
@BeforeEach
12+
void setUp() {
13+
storageConnectorFactory = new StorageConnectorFactory();
14+
StorageConnectorConfiguration configuration = new StorageConnectorConfiguration();
15+
configuration.setType(StorageConnectorOptions.S3.getStringValue());
16+
storageConnectorFactory.setConfiguration(configuration);
17+
}
18+
19+
@Test
20+
void storageConnectorFactoryReturnsS3StorageConnectorTest() {
21+
StorageConnector storageConnector = storageConnectorFactory.getObject();
22+
23+
assertInstanceOf(S3StorageConnector.class, storageConnector);
24+
}
25+
}

0 commit comments

Comments
 (0)