Skip to content

Commit 65d36d0

Browse files
committed
Minor changes.
1 parent e032788 commit 65d36d0

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapper.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@
3333

3434
import uk.nhs.adaptors.gp2gp.common.service.ConfidentialityService;
3535
import uk.nhs.adaptors.gp2gp.common.service.RandomIdGeneratorService;
36-
import uk.nhs.adaptors.gp2gp.ehr.mapper.CommentType;
37-
import uk.nhs.adaptors.gp2gp.ehr.mapper.IdMapper;
38-
import uk.nhs.adaptors.gp2gp.ehr.mapper.MessageContext;
39-
import uk.nhs.adaptors.gp2gp.ehr.mapper.ParticipantMapper;
40-
import uk.nhs.adaptors.gp2gp.ehr.mapper.ParticipantType;
36+
import uk.nhs.adaptors.gp2gp.ehr.mapper.*;
4137
import uk.nhs.adaptors.gp2gp.ehr.mapper.parameters.diagnosticreport.DiagnosticReportCompoundStatementTemplateParameters;
4238
import uk.nhs.adaptors.gp2gp.ehr.mapper.parameters.diagnosticreport.NarrativeStatementTemplateParameters;
4339
import uk.nhs.adaptors.gp2gp.ehr.utils.CodeableConceptMappingUtils;
@@ -114,6 +110,9 @@ private String fetchExtensionId(List<Identifier> identifiers) {
114110
}
115111

116112
private List<Specimen> fetchSpecimens(DiagnosticReport diagnosticReport) {
113+
114+
//if there are any orphan diagnostic reports, add a dummy specimen to each of them
115+
117116
if (!diagnosticReport.hasSpecimen()) {
118117
return Collections.singletonList(generateDefaultSpecimen(diagnosticReport));
119118
}
@@ -143,7 +142,7 @@ private List<Observation> fetchObservations(DiagnosticReport diagnosticReport) {
143142
return Collections.singletonList(generateDefaultObservation(diagnosticReport));
144143
}
145144

146-
var inputBundleHolder = messageContext.getInputBundleHolder();
145+
InputBundle inputBundleHolder = messageContext.getInputBundleHolder();
147146
return diagnosticReport.getResult().stream()
148147
.map(Reference::getReferenceElement)
149148
.map(inputBundleHolder::getResource)

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/ObservationMapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ private String prepareStatementsForDerivedObservations(List<MultiStatementObserv
421421
StringBuilder derivedObservationsBlock = new StringBuilder();
422422

423423
derivedObservations.forEach(derivedObservationHolder -> {
424-
var derivedObservation = derivedObservationHolder.getObservation();
424+
Observation derivedObservation = derivedObservationHolder.getObservation();
425425
Optional<String> observationStatement =
426426
prepareObservationStatement(derivedObservationHolder, CompoundStatementClassCode.CLUSTER);
427427
Optional<String> narrativeStatements = prepareNarrativeStatements(

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapperTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,6 @@ public void setUp() throws IOException {
115115
when(idMapper.getOrNew(any(ResourceType.class), any(IdType.class))).thenAnswer(mockIdForResourceAndId());
116116
when(agentDirectory.getAgentId(any(Reference.class))).thenAnswer(mockIdForReference());
117117
when(randomIdGeneratorService.createNewId()).thenReturn(TEST_ID);
118-
when(specimenMapper.mapSpecimenToCompoundStatement(any(Specimen.class), anyList(), any(DiagnosticReport.class)))
119-
.thenAnswer(mockSpecimenMapping());
120118
when(codeableConceptCdMapper.mapCodeableConceptToCd(any(CodeableConcept.class)))
121119
.thenReturn(CodeableConceptMapperMockUtil.NULL_FLAVOR_CODE);
122120

0 commit comments

Comments
 (0)