Move log entry below action, and be specific about task + conversationID

adrianclay · adrianclay · commit 73c5eacd560d · 2024-11-26T11:45:54.000Z
diff --git a/service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/EhrResendController.java b/service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/EhrResendController.java
@@ -68,10 +68,10 @@ public ResponseEntity<String> scheduleEhrExtractResend(@PathVariable String conv
             return new ResponseEntity<>(errorBody, HttpStatus.CONFLICT);
         }
 
-        LOGGER.info("Creating tasks to start the EHR Extract process resend");
         var updatedEhrExtractStatus = prepareEhrExtractStatusForNewResend(ehrExtractStatus);
         ehrExtractStatusRepository.save(updatedEhrExtractStatus);
         createGetGpcStructuredTask(updatedEhrExtractStatus);
+        LOGGER.info("Scheduled GetGpcStructuredTask for resend of ConversationId: {}", conversationId);
 
         return new ResponseEntity<>(HttpStatus.ACCEPTED);
     }

Original file line number	Diff line number	Diff line change
`@@ -68,10 +68,10 @@ public ResponseEntity<String> scheduleEhrExtractResend(@PathVariable String conv`
`68`	`68`	`return new ResponseEntity<>(errorBody, HttpStatus.CONFLICT);`
`69`	`69`	`}`
`70`	`70`
`71`		`- LOGGER.info("Creating tasks to start the EHR Extract process resend");`
`72`	`71`	`var updatedEhrExtractStatus = prepareEhrExtractStatusForNewResend(ehrExtractStatus);`
`73`	`72`	`ehrExtractStatusRepository.save(updatedEhrExtractStatus);`
`74`	`73`	`createGetGpcStructuredTask(updatedEhrExtractStatus);`
	`74`	`+ LOGGER.info("Scheduled GetGpcStructuredTask for resend of ConversationId: {}", conversationId);`
`75`	`75`
`76`	`76`	`return new ResponseEntity<>(HttpStatus.ACCEPTED);`
`77`	`77`	`}`