Update invalid prescription type exception when mapping MedicationStatement (#1110)

* Update message to be clearer and more informative to the user.
* Add test to ensure exception is thrown and the message is correct.
* Add input JSON file for the above test

Author: MartinWheelerMT

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/MedicationStatementMapper.java

@@ -71,6 +71,7 @@ public class MedicationStatementMapper {
     private static final List<String> REPEAT_PRESCRIPTION_TYPE_CODES =
         Arrays.asList("delayed-prescribing", "repeat", "repeat-dispensing");
     private static final String ACUTE_REPEAT_VALUE = "0";
+    private static final String INVALID_PRESCRIPTION_TYPE_MESSAGE = "Could not resolve Prescription Type of `%s` in %s";
 
     private final MessageContext messageContext;
     private final CodeableConceptCdMapper codeableConceptCdMapper;
@@ -254,7 +255,7 @@ private String buildRepeatNumber(MedicationRequest medicationRequest) {
             } else if (prescriptionTypeCode.isBlank() && prescriptionTypeTextIsNoInfoAvailable(medicationRequest)) {
                 return extractRepeatValue(medicationRequest);
             }
-            throw new EhrMapperException("Could not resolve Prescription Type for Repeat value");
+            throw new EhrMapperException(INVALID_PRESCRIPTION_TYPE_MESSAGE.formatted(prescriptionTypeCode, medicationRequest.getId()));
         }
         return StringUtils.EMPTY;
     }

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/MedicationStatementMapperTest.java

@@ -373,6 +373,19 @@ public void When_ConfidentialityServiceReturnsEmptyOptional_Expect_MessageDoesNo
             .doesNotContain(CONFIDENTIALITY_CODE);
     }
 
+    @Test
+    void When_MedicationRequestPlanHasInvalidPrescriptionType_Expect_EhrMapperExceptionThrown() {
+        final var jsonInput = ResourceTestFileUtils.getFileContent(TEST_FILE_DIRECTORY + "mr-plan-with-invalid-prescription-type.json");
+        final var parsedMedicationRequest = new FhirParseService()
+            .parseResource(jsonInput, MedicationRequest.class);
+
+        var exception = assertThrows(
+            EhrMapperException.class,
+            () -> medicationStatementMapper.mapMedicationRequestToMedicationStatement(parsedMedicationRequest));
+
+        assertThat(exception.getMessage()).isEqualTo("Could not resolve Prescription Type of `invalid-type` in MedicationRequest/789");
+    }
+
     private void assertXmlIsEqual(String outputString, String expected) {
 
         Diff diff = DiffBuilder.compare(outputString).withTest(expected)

service/src/test/resources/ehr/mapper/medication_request/mr-plan-with-invalid-prescription-type.json

@@ -0,0 +1,57 @@
+{
+    "resourceType": "MedicationRequest",
+    "id": "789",
+    "meta": {
+        "profile": [
+            "https://fhir.nhs.uk/STU3/StructureDefinition/CareConnect-GPC-MedicationRequest-1"
+        ]
+    },
+    "extension": [
+        {
+            "url": "https://fhir.nhs.uk/STU3/StructureDefinition/Extension-CareConnect-GPC-PrescriptionType-1",
+            "valueCodeableConcept": {
+                "coding": [
+                    {
+                        "system": "https://fhir.nhs.uk/STU3/CodeSystem/CareConnect-PrescriptionType-1",
+                        "code": "invalid-type",
+                        "display": "Invalid Type"
+                    }
+                ]
+            }
+        }
+    ],
+    "status": "completed",
+    "intent": "plan",
+    "medicationReference": {
+        "reference": "Medication/20"
+    },
+    "authoredOn": "2022-10-04",
+    "recorder": {
+        "reference": "Practitioner/1332aa9c-28d6-11eb-adc1-0242ac120002"
+    },
+    "requester": {
+        "agent": {
+            "reference": "Organization/F85003"
+        }
+    },
+    "dosageInstruction": [
+        {
+            "text": "One puff as needed. Max 10 doses per day"
+        }
+    ],
+    "dispenseRequest": {
+        "validityPeriod": {
+            "start": "2022-10-04",
+            "end": "2022-11-01"
+        },
+        "quantity": {
+            "value": 1,
+            "unit": "dose"
+        },
+        "expectedSupplyDuration": {
+            "value": 28,
+            "system": "http://unitsofmeasure.org",
+            "code": "d"
+        }
+    }
+}