Skip to content

Commit 851381d

Browse files
authored
Temporary disabling changes introduced in NIAD-3153 and NIAD-3154 (#1174)
* temporary disabling changes introduced in NIAD-3153 and NIAD-3154 * spotbugs
1 parent 74c048e commit 851381d

File tree

9 files changed

+4
-16
lines changed

9 files changed

+4
-16
lines changed

CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ In the case that neither of these are present, the existing behavior of using th
1515
### Added
1616

1717
* GP2GP Adaptor now populates the PlanStatement / confidentialityCode field when the ProcedureRequest.meta.security field contains NOPAT
18-
* When the ReferralRequest.meta.security field contains NOPAT, the GP2GP Adaptor will now populate the RequestStatement / confidentialityCode field accordingly.
19-
* The GP2GP Adaptor now populates the CompoundStatement / confidentialityCode field when Observation.meta.security field contains NOPAT
2018

2119
## [2.2.2] - 2025-02-07
2220

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/BloodPressureMapper.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,11 @@ public class BloodPressureMapper {
6262

6363
public String mapBloodPressure(Observation observation, boolean isNested) {
6464

65-
var confidentialityCode = confidentialityService.generateConfidentialityCode(observation);
66-
6765
BloodPressureParametersBuilder builder = BloodPressureParameters.builder()
6866
.isNested(isNested)
6967
.id(messageContext.getIdMapper().getOrNew(ResourceType.Observation, observation.getIdElement()))
7068
.effectiveTime(prepareEffectiveTimeForObservation(observation))
7169
.availabilityTime(prepareAvailabilityTimeForObservation(observation))
72-
.confidentialityCode(confidentialityCode.orElse(null))
7370
.compoundStatementCode(buildBloodPressureCode(observation));
7471

7572
extractBloodPressureComponent(observation, SYSTOLIC_CODE).ifPresent(observationComponent -> {

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/RequestStatementMapper.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,11 @@ private String map() {
103103
processAgent(agentRef, onBehalfOf);
104104
}
105105

106-
var confidentialityCode = confidentialityService.generateConfidentialityCode(referralRequest);
107-
108106
final IdMapper idMapper = messageContext.getIdMapper();
109107
templateParameters
110108
.requestStatementId(idMapper.getOrNew(ResourceType.ReferralRequest, referralRequest.getIdElement()))
111109
.isNested(isNested)
112110
.availabilityTime(StatementTimeMappingUtils.prepareAvailabilityTime(referralRequest.getAuthoredOnElement()))
113-
.confidentialityCode(confidentialityCode.orElse(null))
114111
.text(buildTextDescription())
115112
.priorityCode(buildPriorityCode())
116113
.code(buildCode());

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/parameters/BloodPressureParameters.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,4 @@ public class BloodPressureParameters {
2323
private String systolicCode;
2424
private String diastolicCode;
2525
private String participant;
26-
private String confidentialityCode;
2726
}

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/parameters/RequestStatementTemplateParameters.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,4 @@ public class RequestStatementTemplateParameters {
1717
private String participant;
1818
private String responsibleParty;
1919
private String text;
20-
private String confidentialityCode;
2120
}

service/src/main/resources/templates/ehr_compound_statement_blood_pressure_template.mustache

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
{{{effectiveTime}}}
88
</effectiveTime>
99
{{{availabilityTime}}}
10-
{{#confidentialityCode}}
11-
{{{confidentialityCode}}}
12-
{{/confidentialityCode}}
1310
{{#systolicId}}
1411
<component typeCode="COMP" contextConductionInd="true">
1512
<ObservationStatement classCode="OBS" moodCode="EVN">

service/src/main/resources/templates/ehr_request_statement_template.mustache

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010
<center nullFlavor="NI"/>
1111
</effectiveTime>
1212
{{{availabilityTime}}}
13-
{{#confidentialityCode}}
14-
{{{confidentialityCode}}}
15-
{{/confidentialityCode}}
1613
{{#priorityCode}}
1714
{{{priorityCode}}}
1815
{{/priorityCode}}

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/BloodPressureMapperTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.hl7.fhir.dstu3.model.Observation;
66
import org.junit.jupiter.api.AfterEach;
77
import org.junit.jupiter.api.BeforeEach;
8+
import org.junit.jupiter.api.Disabled;
89
import org.junit.jupiter.api.Test;
910
import org.junit.jupiter.api.extension.ExtendWith;
1011
import org.junit.jupiter.params.ParameterizedTest;
@@ -94,6 +95,7 @@ public void tearDown() {
9495
messageContext.resetMessageContext();
9596
}
9697

98+
@Disabled
9799
@Test
98100
public void When_MappingBloodPressureWithNopat_Expect_CompoundStatementWithConfidentialityCode() {
99101
when(mockCodeableConceptCdMapper.mapCodeableConceptToCdForBloodPressure(any(CodeableConcept.class)))

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/RequestStatementMapperTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import org.hl7.fhir.dstu3.model.ResourceType;
1919
import org.junit.jupiter.api.AfterEach;
2020
import org.junit.jupiter.api.BeforeEach;
21+
import org.junit.jupiter.api.Disabled;
2122
import org.junit.jupiter.api.Test;
2223
import org.junit.jupiter.api.extension.ExtendWith;
2324
import org.junit.jupiter.params.ParameterizedTest;
@@ -359,6 +360,7 @@ public void When_MappingReferralRequestJsonWithNestedTrue_Expect_RequestStatemen
359360
assertThat(outputMessage).isEqualTo(expectedOutputMessage);
360361
}
361362

363+
@Disabled
362364
@Test
363365
public void When_MappingReferralRequestWithNoPat_Expect_RequestStatementWithConfidentialityCode() {
364366
when(confidentialityService.generateConfidentialityCode(any(ReferralRequest.class)))

0 commit comments

Comments
 (0)