Skip to content

Commit 8e677d2

Browse files
author
Adrian Clay
authored
Remove unnecessary if statement (#1070)
This was picked up by pitest as being unnecessary
1 parent f7394d9 commit 8e677d2

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapper.java

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -231,16 +231,12 @@ private List<Observation> addDummyObservationsToObservationList(
231231
List<Observation> completeObservations = new ArrayList<>();
232232
completeObservations.addAll(observations);
233233

234-
if (hasSpecimenWithoutObservation(specimens, observations)) {
235-
List<String> specimensWithoutObservations = getSpecimenIdsWithoutObservation(specimens, observations);
236-
237-
// Generate a dummy Observation for each Specimen without an Observation
238-
for (String specimenWithoutObservations : specimensWithoutObservations) {
239-
Observation dummyObservation = generateDummyObservation(diagnosticReport);
240-
Reference specimenReference = new Reference(specimenWithoutObservations);
241-
dummyObservation.setSpecimen(specimenReference);
242-
completeObservations.add(dummyObservation);
243-
}
234+
// Generate a dummy Observation for each Specimen without an Observation
235+
for (String specimenWithoutObservations : getSpecimenIdsWithoutObservation(specimens, observations)) {
236+
Observation dummyObservation = generateDummyObservation(diagnosticReport);
237+
Reference specimenReference = new Reference(specimenWithoutObservations);
238+
dummyObservation.setSpecimen(specimenReference);
239+
completeObservations.add(dummyObservation);
244240
}
245241

246242
return completeObservations;
@@ -271,12 +267,6 @@ private List<String> getSpecimenIdsWithoutObservation(List<Specimen> specimens,
271267
return specimensWithoutObservations;
272268
}
273269

274-
private boolean hasSpecimenWithoutObservation(List<Specimen> specimens, List<Observation> observations) {
275-
List<String> specimensWithoutObservations = getSpecimenIdsWithoutObservation(specimens, observations);
276-
277-
return !specimensWithoutObservations.isEmpty();
278-
}
279-
280270
private Observation generateDummyObservation(DiagnosticReport diagnosticReport) {
281271
Observation observation = new Observation();
282272

0 commit comments

Comments
 (0)