Skip to content

Commit 8f6795e

Browse files
Non-constant string concatenation as argument to logging call (#999)
Code Quality fix for non-constant string concatenation when logging in MockMhsService
1 parent a8ce62e commit 8f6795e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mock-mhs-adaptor/src/main/java/uk/nhs/adaptors/mockmhsservice/service/MockMhsService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public ResponseEntity<String> handleRequest(String interactionId, String correla
7575
EHR_EXTRACT_ID_MAP.put(correlationId, messageId);
7676
var inboundMessage = STUB_CONTINUE_REPLY_INBOUND_MESSAGE.replace("%%ConversationId%%", correlationId);
7777
inboundProducer.sendToMhsInboundQueue(inboundMessage);
78-
LOGGER.info("Placed message on Inbound Queue, conversationId: " + correlationId);
78+
LOGGER.info("Placed message on Inbound Queue, conversationId: {}", correlationId);
7979
headers.setContentType(MediaType.TEXT_XML);
8080
return new ResponseEntity<>(STUB_ACCEPTED_RESPONSE, headers, ACCEPTED);
8181
} catch (JmsException e) {
@@ -94,7 +94,7 @@ public ResponseEntity<String> handleRequest(String interactionId, String correla
9494
}
9595

9696
inboundProducer.sendToMhsInboundQueue(inboundMessage);
97-
LOGGER.info("Message acknowledgement sent to Inbound Queue, conversationId: " + correlationId);
97+
LOGGER.info("Message acknowledgement sent to Inbound Queue, conversationId: {}", correlationId);
9898
headers.setContentType(MediaType.TEXT_XML);
9999
return new ResponseEntity<>(STUB_ACCEPTED_RESPONSE, headers, ACCEPTED);
100100
} catch (JmsException e) {

0 commit comments

Comments
 (0)