NIAD-1136: Remove lenient mocking from ConditionLinkSetMapperTests (#1408)

* Remove lenient stubbing from `ConditionLinkSetMapper`

* Refactor `ConditionLinkSetMapper` to remove lenient stubbing.
* Inline single use constants.
* Move shared stubbing to reusable methods.
* Regroup / extract tests from parameterized tests which relied on lenient mocking.
* Move condition tests code to `CodeableConceptMapperMockUtil`.

* * Update test files so that they use real examples, as previously the same ID was being provided for conditions and the actual problem observation.
* Remove duplicated tests / test files when inputs and expected outputs were the same.

Author: MartinWheelerMT

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/ConditionLinkSetMapperTest.java

@@ -4,4 +4,8 @@ public class CodeableConceptMapperMockUtil {
     public static final String NULL_FLAVOR_CODE = "<code nullFlavor=\"UNK\"><originalText>Mocked code</originalText></code>";
     public static final String ACTUAL_PROBLEM_CODE =
             "<code code=\"55607006\" codeSystem=\"2.16.840.1.113883.2.1.3.2.4.15\" displayName=\"Problem\">";
+    public static final String TEST_CONDITION_CODE =
+        "<code code=\"55607006\" codeSystem=\"2.16.840.1.113883.2.1.3.2.4.15\" displayName=\"Problem\">"
+            + "<originalText>Test Condition</originalText></code>";
+
 }

service/src/test/java/uk/nhs/adaptors/gp2gp/utils/CodeableConceptMapperMockUtil.java

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {

service/src/test/resources/ehr/mapper/condition/condition_2_related_clinical_content.json

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {

service/src/test/resources/ehr/mapper/condition/condition_all_included.json

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {

service/src/test/resources/ehr/mapper/condition/condition_asserter_not_practitioner.json

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {

service/src/test/resources/ehr/mapper/condition/condition_asserter_not_present.json

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {

service/src/test/resources/ehr/mapper/condition/condition_dates_not_present.json

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {

service/src/test/resources/ehr/mapper/condition/condition_dates_present.json

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {

service/src/test/resources/ehr/mapper/condition/condition_major_significance.json

@@ -10,7 +10,7 @@
         {
             "url": "https://fhir.hl7.org.uk/STU3/StructureDefinition/Extension-CareConnect-ActualProblem-1",
             "valueReference": {
-                "reference": "Observation/7E277DF1-6F1C-47CD-84F7-E9B7BF4105DB"
+                "reference": "Observation/CDF96FF9-267A-41F7-93A1-BEBDCDEC2B98"
             }
         },
         {