Prevent duplicate dummy observations when DiagnosticReport has no restults.

Author: Alex-Nita

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapper.java

@@ -200,7 +200,7 @@ private Specimen generateDummySpecimen(DiagnosticReport diagnosticReport) {
 
     private List<Observation> fetchObservations(DiagnosticReport diagnosticReport) {
         if (!diagnosticReport.hasResult()) {
-            return Collections.singletonList(generateDefaultObservation(diagnosticReport));
+            return Collections.emptyList();
         }
 
         var inputBundleHolder = messageContext.getInputBundleHolder();
@@ -219,7 +219,8 @@ private List<Observation> addDummyObservationsToObservationList(
             List<Observation> observations,
             List<Specimen> specimens,
             DiagnosticReport diagnosticReport) {
-        List<Observation> dummyObservations = new ArrayList<>();
+        List<Observation> completeObservations = new ArrayList<>();
+        completeObservations.addAll(observations);
 
         if (hasSpecimenWithoutObservation(specimens, observations)) {
             List<String> specimensWithoutObservations = getSpecimenIdsWithoutObservation(specimens, observations);
@@ -229,12 +230,11 @@ private List<Observation> addDummyObservationsToObservationList(
                 Observation dummyObservation = generateDefaultObservation(diagnosticReport);
                 Reference specimenReference = new Reference(specimenWithoutObservations);
                 dummyObservation.setSpecimen(specimenReference);
-                dummyObservations.add(dummyObservation);
+                completeObservations.add(dummyObservation);
             }
         }
 
-        observations.addAll(dummyObservations);
-        return observations;
+        return completeObservations;
     }
 
     private List<String> getSpecimenIdsWithoutObservation(List<Specimen> specimens, List<Observation> observations) {