Upgrade checkstyle to latest version (#938)

* Upgrade checkstyle to latest version

* Resolve "Class … should be declared as final." checkstyle errors

Author: Adrian Clay

service/build.gradle

@@ -24,7 +24,7 @@ group = 'uk.nhs.adaptors'
 sourceCompatibility = '21'
 
 checkstyle {
-	toolVersion '8.38'
+	toolVersion '10.18.2'
 	configDirectory = 'checkstyle' as File
 }
 

service/src/main/java/uk/nhs/adaptors/gp2gp/common/configuration/CustomTrustStore.java

@@ -78,7 +78,7 @@ private X509TrustManager getCustomDbTrustManager(AmazonS3URI s3URI, String trust
     }
 
     @RequiredArgsConstructor
-    private static class CombinedTrustManager implements X509TrustManager {
+    private static final class CombinedTrustManager implements X509TrustManager {
         private final X509TrustManager primaryTrustManager;
         private final X509TrustManager secondaryTrustManager;
 

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/RequestStatementMapper.java

@@ -90,7 +90,7 @@ public String mapReferralRequestToRequestStatement(ReferralRequest referralReque
     }
 
     @RequiredArgsConstructor
-    private class InnerMapper {
+    private final class InnerMapper {
         private final ReferralRequest referralRequest;
         private final boolean isNested;
         private final RequestStatementTemplateParametersBuilder templateParameters = RequestStatementTemplateParameters.builder();

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/utils/XpathExtractor.java

@@ -334,7 +334,7 @@ private static String buildAvailabilityTimeTemplate(String time) {
 
     @Data
     @Builder
-    private static class EhrTemplateArgs {
+    private static final class EhrTemplateArgs {
         private String availabilityTime;
         private String effectiveTime;
         private String effectiveTimeBackup;

service/src/test/java/uk/nhs/adaptors/gp2gp/gpc/TaskExecutorFactoryTest.java

@@ -68,7 +68,7 @@ public void When_GettingValidTask_Expect_TaskDefinitionFactoryReturnsCorrectTask
     }
 
     @SuperBuilder
-    private static class NoExecutorTaskDefinition extends TaskDefinition {
+    private static final class NoExecutorTaskDefinition extends TaskDefinition {
         @Override
         public TaskType getTaskType() {
             return null;