addressing sonarQube improvement suggestion

ORybak5 · ORybak5 · commit c86cf779b15f · 2024-11-21T12:37:34.000Z
diff --git a/service/src/main/java/uk/nhs/adaptors/gp2gp/common/service/FhirParseService.java b/service/src/main/java/uk/nhs/adaptors/gp2gp/common/service/FhirParseService.java
@@ -21,10 +21,7 @@ public <T extends IBaseResource> T parseResource(String body, Class<T> fhirClass
     }
 
     public String encodeToJson(IBaseResource resource) {
-        IParser jsonParser = prepareParser();
-        return jsonParser
-            .setPrettyPrint(true)
-            .encodeResourceToString(resource);
+        return jsonParser.setPrettyPrint(true).encodeResourceToString(resource);
     }
 
     private IParser prepareParser() {

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,7 @@ public <T extends IBaseResource> T parseResource(String body, Class<T> fhirClass`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public String encodeToJson(IBaseResource resource) {`
`24`		`- IParser jsonParser = prepareParser();`
`25`		`- return jsonParser`
`26`		`- .setPrettyPrint(true)`
`27`		`- .encodeResourceToString(resource);`
	`24`	`+ return jsonParser.setPrettyPrint(true).encodeResourceToString(resource);`
`28`	`25`	`}`
`29`	`26`
`30`	`27`	`private IParser prepareParser() {`