Removed lenient from DocumentToMHSTranslatorTest

Author: chiaramapellimt

service/src/test/java/uk/nhs/adaptors/gp2gp/gpc/DocumentToMHSTranslatorTest.java

@@ -7,8 +7,6 @@
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-import org.mockito.junit.jupiter.MockitoSettings;
-import org.mockito.quality.Strictness;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import uk.nhs.adaptors.gp2gp.common.service.FhirParseService;
 import uk.nhs.adaptors.gp2gp.common.service.RandomIdGeneratorService;
@@ -23,7 +21,6 @@
 import static org.mockito.Mockito.when;
 
 @ExtendWith(MockitoExtension.class)
-@MockitoSettings(strictness = Strictness.LENIENT)
 public class DocumentToMHSTranslatorTest {
     private static final String TEST_FILE_DIRECTORY = "/ehr/request/fhir/";
     private static final String INPUT_DIRECTORY = "input/";
@@ -69,8 +66,8 @@ public static void initialize() {
 
     @BeforeEach
     public void setUp() {
-        when(timestampService.now()).thenReturn(Instant.parse(TEST_DATE_TIME));
-        when(randomIdGeneratorService.createNewId()).thenReturn(TEST_ID);
+//        when(timestampService.now()).thenReturn(Instant.parse(TEST_DATE_TIME));
+//        when(randomIdGeneratorService.createNewId()).thenReturn(TEST_ID);
 
         documentToMHSTranslator = new DocumentToMHSTranslator(
             new ObjectMapper(),
@@ -79,6 +76,9 @@ public void setUp() {
 
     @Test
     void When_TranslatingDocumentData_Expect_ProperMhsOutboundRequestPayload() {
+        when(timestampService.now()).thenReturn(Instant.parse(TEST_DATE_TIME));
+        when(randomIdGeneratorService.createNewId()).thenReturn(TEST_ID);
+
         GetGpcDocumentTaskDefinition taskDefinition = GetGpcDocumentTaskDefinition.builder()
             .messageId(MESSAGE_ID)
             .documentId(TEST_DOCUMENT_ID)
@@ -92,6 +92,9 @@ void When_TranslatingDocumentData_Expect_ProperMhsOutboundRequestPayload() {
 
     @Test
     void When_TranslatingFileContentData_Expect_ProperMhsOutboundRequestPayload() {
+        when(timestampService.now()).thenReturn(Instant.parse(TEST_DATE_TIME));
+        when(randomIdGeneratorService.createNewId()).thenReturn(TEST_ID);
+
         final GetAbsentAttachmentTaskDefinition taskDefinition = GetAbsentAttachmentTaskDefinition.builder()
             .title(TEST_TITLE)
             .messageId(MESSAGE_ID)