tests fix for the new error code

Author: ORybak5

service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/EhrResendController.java

@@ -30,8 +30,8 @@
 public class EhrResendController {
 
     private static final String OPERATION_OUTCOME_URL = "https://fhir.nhs.uk/STU3/StructureDefinition/GPConnect-OperationOutcome-1";
-    public static final String FORBIDDEN = "FORBIDDEN";
-    public static final String INVALID_IDENTIFIER_VALUE = "INVALID_IDENTIFIER_VALUE";
+    private static final String FORBIDDEN = "FORBIDDEN";
+    private static final String INVALID_IDENTIFIER_VALUE = "INVALID_IDENTIFIER_VALUE";
 
     private EhrExtractStatusRepository ehrExtractStatusRepository;
     private TaskDispatcher taskDispatcher;

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/EhrResendControllerTest.java

@@ -46,7 +46,7 @@ class EhrResendControllerTest {
     private static final String FROM_ASID_CODE = "test-from-asid";
     private static final String INCUMBENT_NACK_CODE = "99";
     private static final String INCUMBENT_NACK_DISPLAY = "Unexpected condition.";
-    private static final String INTERNAL_SERVER_ERROR = "INTERNAL_SERVER_ERROR";
+    private static final String FORBIDDEN = "FORBIDDEN";
     private static final String GPCONNECT_ERROR_OR_WARNING_CODE = "http://fhir.nhs.net/ValueSet/gpconnect-error-or-warning-code-1";
     private static final String INVALID_IDENTIFIER_VALUE = "INVALID_IDENTIFIER_VALUE";
     public static final String ISSUE_CODE_VALUE = "value";
@@ -144,7 +144,7 @@ void When_AnEhrExtractHasNotFailedAndAnotherResendRequestArrives_Expect_FailedOp
         JsonNode rootNode = objectMapper.readTree(response.getBody());
 
         assertAll(
-            () -> assertResponseHasExpectedOperationOutcome(rootNode, INTERNAL_SERVER_ERROR, DIAGNOSTICS_MSG, ISSUE_CODE_BUSINESS_RULE),
+            () -> assertResponseHasExpectedOperationOutcome(rootNode, FORBIDDEN, DIAGNOSTICS_MSG, ISSUE_CODE_BUSINESS_RULE),
             () -> assertEquals(HttpStatus.FORBIDDEN, response.getStatusCode())
         );
     }
@@ -199,7 +199,7 @@ void When_AnEhrExtractHasNotFailed_Expect_RespondsWith403() throws JsonProcessin
         JsonNode rootNode = objectMapper.readTree(response.getBody());
 
         assertAll(
-            () -> assertResponseHasExpectedOperationOutcome(rootNode, INTERNAL_SERVER_ERROR, DIAGNOSTICS_MSG, ISSUE_CODE_BUSINESS_RULE),
+            () -> assertResponseHasExpectedOperationOutcome(rootNode, FORBIDDEN, DIAGNOSTICS_MSG, ISSUE_CODE_BUSINESS_RULE),
             () -> assertEquals(HttpStatus.FORBIDDEN, response.getStatusCode())
         );
     }