Skip to content

Conversation

@Alex-Nita
Copy link
Contributor

What

Changed DiagnosticReportMapper to not send duplicated Test Reports to SpecimenMapper

Why

Duplicated test reports were appearing in the generated xml.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies to the reviewer - The existing file was very poorly formatted making any changes very hard to make. You can find the actual difference in values here: b298406#diff-985e27182cd9375e604dc2c64df1af502c7df8e6d2bffbdcc3ef454d88df22d4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made because the Observation referenced had a specimen referenced that was NOT included in the diagnostic report. The new referenced observation had no specimen referenced at all (Which is what the test is intended to test).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observation used for this test was changed, see comment

@Alex-Nita Alex-Nita marked this pull request as ready for review November 26, 2024 13:41
@github-actions
Copy link

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 4
class surviving killed
🧟uk.nhs.adaptors.gp2gp.ehr.mapper.diagnosticreport.DiagnosticReportMapper 1 4

See https://pitest.org

@sonarqubecloud
Copy link

@adrianclay adrianclay merged commit 7907883 into main Nov 26, 2024
14 checks passed
@adrianclay adrianclay deleted the NIAD-3217-fix-duplicate-test-results branch November 26, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants